Include optional namespace in keycloak-operator templates#1274
Include optional namespace in keycloak-operator templates#1274gwydionmv wants to merge 3 commits intoadfinis:mainfrom
Conversation
github-actions
bot
added
the
size/L
gwydionmv
force-pushed
the
feature/include-optional-namespace
branch
from
d5737e6 to
62482c9
Compare
github-actions
bot
added
size/M
tongpu
left a comment
tongpu
left a comment
There was a problem hiding this comment.
I've left a few comments for you to consider.
Please make sure to also reflect the change in values.yaml, maybe with a commented out line showing how it can be used. Using namespace: "" might also work, because I think Helm treats empty string as if they don't exist.
| {{- with .Values.operator.namespace }} | ||
| namespace: {{ . }} | ||
| {{- end }} |
There was a problem hiding this comment.
ClusterRoles are not namespaced, so this is not required here.
| {{- with .Values.operator.namespace }} | |
| namespace: {{ . }} | |
| {{- end }} |
| {{- with .Values.operator.namespace }} | ||
| namespace: {{ . }} | ||
| {{- end }} |
There was a problem hiding this comment.
ClusterRoles are not namespaced, so this is not required here.
| {{- with .Values.operator.namespace }} | |
| namespace: {{ . }} | |
| {{- end }} |
| {{- with .Values.operator.namespace }} | ||
| namespace: {{ . }} | ||
| {{- end }} |
There was a problem hiding this comment.
Is it also required that you can deploy the operator in another namespace the the one the Helm chart is being deployed into?
I can fully understand that you would want this for the keycloak instances, but the operator would be deployed in a central namespace right?
2 participants
Description
Included optional namespace field in the keycloak-operator templates.
Checklist
artifacthub.io/changesannotation inChart.yaml, check the example in the documentation.pre-commit rundocs/