feat(openshift-etcd-backup): add AlertingRule for monitoring etcd backup on OpenShift#1375
Draft
feat(openshift-etcd-backup): add AlertingRule for monitoring etcd backup on OpenShift#1375
Conversation
github-actions
bot
added
the
size/L
vmaillot
reviewed
Mar 5, 2025
| groups: | ||
| - name: cronjob-monitor | ||
| rules: | ||
| - alert: EtcdBackupCronJobStatusFailed |
Contributor
There was a problem hiding this comment.
don't we already have this in place? Please see current alert.
Contributor
Author
There was a problem hiding this comment.
🤔 there are scenarios where the existing PrometheusRule based alert works. I'll have to revisit the reason for this change, i'm currently not sure why the PromtheusRule works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds an AlertingRule as described on https://docs.openshift.com/container-platform/4.18///observability/monitoring/managing-alerts/managing-alerts-as-an-administrator.html#creating-new-alerting-rules_managing-alerts-as-an-administrator.
Also adds test for the
openshift-etcd-backupHelm chart.Issues
Checklist
artifacthub.io/changesannotation inChart.yaml, check the example in the documentation.pre-commit rundocs/