Skip to content

feat!: bump hedgedoc version to 1.10.7, move to cloudpirates chart#1695

Open
gianklug wants to merge 5 commits intomainfrom
fix/hedgedoc/1_10_6
Open

feat!: bump hedgedoc version to 1.10.7, move to cloudpirates chart#1695
gianklug wants to merge 5 commits intomainfrom
fix/hedgedoc/1_10_6

Conversation

@gianklug
Copy link
Copy Markdown
Member

Description

Issues

Checklist

  • This PR contains a description of the changes I'm making
  • I updated the version in Chart.yaml
  • I updated the changelog with an artifacthub.io/changes annotation in Chart.yaml, check the example in the documentation.
  • I updated applicable README.md files using pre-commit run
  • I documented any high-level concepts I'm introducing in docs/
  • CI is currently green and this is ready for review
  • I am ready to test changes after they are applied and released

@gianklug gianklug requested a review from hairmare February 23, 2026 06:20
@gianklug gianklug requested review from a team and altesockensuppe as code owners February 23, 2026 06:20
@gianklug gianklug requested a review from cfi2017 February 23, 2026 06:20
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 23, 2026
@gianklug gianklug force-pushed the fix/hedgedoc/1_10_6 branch from 88cbe10 to 2b171e3 Compare February 23, 2026 06:28
@gianklug gianklug force-pushed the fix/hedgedoc/1_10_6 branch from 2b171e3 to d01d920 Compare February 23, 2026 06:29
@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 23, 2026
cfi2017
cfi2017 previously approved these changes Feb 23, 2026
@gianklug gianklug enabled auto-merge (squash) February 23, 2026 06:31
@hairmare
Copy link
Copy Markdown
Contributor

It looks like there are some outdated references to bitnami postgresql:

Failed to pull image "docker.io/bitnami/postgresql:15.2.0-debian-11-r2": rpc error: code = NotFound desc = failed to pull and unpack image "docker.io/bitnami/postgresql:15.2.0-debian-11-r2": failed to resolve reference "docker.io/bitnami/postgresql:15.2.0-debian-11-r2": docker.io/bitnami/postgresql:15.2.0-debian-11-r2: not found

These will most likely need to be addressed before we can get this merged.

@gianklug
Copy link
Copy Markdown
Member Author

@hairmare what's the way to go here? We originally started shipping this with a bitnami DB because of the philosophy that every chart should install out of the box (and during linting).

Pivoting away from Bitnami for a minor release would probably be too breaking.

@hairmare
Copy link
Copy Markdown
Contributor

let's ask @c0rydoras how he solved it for the timed chart 😬

@hairmare
Copy link
Copy Markdown
Contributor

that said,,,,

pivoting from bitnami is ok, we might want to mention that the database isn't considered to be part of any breaking api, we recommend that people care about their database and don't manage it via the included chart. The included setup enables PoC work + CI, but it ain't your free ticket to a dba managed env.

@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 2, 2026
@gianklug gianklug changed the title fix: bump hedgedoc version to 1.10.6 feat!: bump hedgedoc version to 1.10.7, move to cloudpirates chart Mar 2, 2026
@gianklug gianklug requested review from cfi2017 and eyenx March 2, 2026 07:07
type: application
version: 0.5.4
appVersion: "1.10.3"
version: 0.5.5
Copy link
Copy Markdown
Member

@pree pree Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned earlier, even if this should not be used for production workloads it could still introduce a breaking change depending on the values used. So I would at least do a minor version bump, instead of just a patch.

Copy link
Copy Markdown
Member Author

@gianklug gianklug Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I upped this to 1.0.0 o_O

this is 100% breaking

-> will update

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that we should stick to semver and even do a major upgrade, but I'll let my colleagues some time to review this too!

IIRC the bitnami chart doesn't set the retention policy to Retain by default, so this could potentially lead to data loss if not investigated correctly on improper setup environments. But still, this is a breaking change, as it also requires changing the values due to the changed value set coming from the dependency.

The only alternative for me would be to remove the database from the dependency completely, either we offer it and handle the weight of it, or we remove it and leave it to the users to bring a DB.

Copy link
Copy Markdown
Contributor

@hairmare hairmare Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sticking to semver includes being allowed to introduce breaking changes at anytime when still using 0.x. I strongly recommend sticking with 0.x for now, if someone requires a 1.x then we would need to put a bit of work into clarifying what it includes.

In this case, the included PostgreSQL should have never been considered to be part of the external API surface, so what we do with it is never a breaking change.

Maybe we should clearly mention that the included database is for CI only and not for production workloads. Maybe that isn't clear enough yet?

BREAKING CHANGE: data needs to manaually be migrated from the bitnami
postgres to the cloudpirates postgres install if an external database
is not used.

Signed-off-by: Gian Klug <gian.klug@adfinis.com>
@gianklug gianklug force-pushed the fix/hedgedoc/1_10_6 branch from 681b988 to 8997156 Compare March 2, 2026 11:14
Co-authored-by: Lucas <116588+hairmare@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants