Skip to content

chore: update links to Adfinis homepage#1724

Draft
tongpu wants to merge 1 commit intoadfinis:mainfrom
tongpu:chore/update_adfinis_links
Draft

chore: update links to Adfinis homepage#1724
tongpu wants to merge 1 commit intoadfinis:mainfrom
tongpu:chore/update_adfinis_links

Conversation

@tongpu
Copy link
Copy Markdown
Member

@tongpu tongpu commented Mar 3, 2026

Description

Update links to Adfinis homepage in README templates

Issues

n/a

Checklist

  • This PR contains a description of the changes I'm making
  • I updated the version in Chart.yaml
  • I updated the changelog with an artifacthub.io/changes annotation in Chart.yaml, check the example in the documentation.
  • I updated applicable README.md files using pre-commit run
  • I documented any high-level concepts I'm introducing in docs/
  • CI is currently green and this is ready for review
  • I am ready to test changes after they are applied and released

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 3, 2026
@tongpu
Copy link
Copy Markdown
Member Author

tongpu commented Mar 3, 2026

@hairmare Any idea how I can skip the "Lint and Install" step without updating the Chart version?

@hairmare
Copy link
Copy Markdown
Contributor

hairmare commented Mar 3, 2026

@tongpu you can't, you'll need to bump versions together with any updates to charts (even if it's just README.md updates).

@tongpu
Copy link
Copy Markdown
Member Author

tongpu commented Mar 3, 2026

@hairmare How would you recommend to proceed?

  • Only update the templates and handle README updates in charts as part of the chart updates
  • Bump the version of every chart

@hairmare
Copy link
Copy Markdown
Contributor

hairmare commented Mar 3, 2026

@tongpu only one of those two solutions will work. You'll have to update versions if you want CI to not fail.

@tongpu tongpu force-pushed the chore/update_adfinis_links branch from f1e973e to 64382e4 Compare March 3, 2026 20:00
@hairmare
Copy link
Copy Markdown
Contributor

i just landed OCI support on main and this is going to be the way we ensure that all things get bumped and also pushed to OCI ;)

@tongpu
Copy link
Copy Markdown
Member Author

tongpu commented Mar 25, 2026

i just landed OCI support on main and this is going to be the way we ensure that all things get bumped and also pushed to OCI ;)

I have a script at the ready to bump the version of all charts and add a changelog item that this is not actually a change, but moving everything to OCI would make it an actual change. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants