Merged
Conversation
install rust-analyser with toolchain ensure that genadl.ts has exit status 1 on failure so that the subsequent ts builds don't run unnecessarily.
Contributor
Author
|
I went ahead and added the custom exception. Adl failures now look like: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
install rust-analyser with toolchain
ensure that genadl.ts has exit status 1 on failure so that the subsequent ts builds don't run unnecessarily.
In the face of ADL compilation errors you still get a fair bit of noise eg:
whereas it would be nice to just have this:
But in problems with the typescript generation code itself, its nice to have the traceback. Ideally, would detect different failure modes, but for now will leave traceback in.