Skip to content

Latest code sync with P1 master#133

Merged
sammy-sandhu merged 2 commits intodevfrom
code-migrations
Aug 19, 2025
Merged

Latest code sync with P1 master#133
sammy-sandhu merged 2 commits intodevfrom
code-migrations

Conversation

@sammy-sandhu
Copy link
Contributor

No description provided.

@sammy-sandhu sammy-sandhu requested a review from ESC8504 August 18, 2025 18:51
Copy link
Contributor

@ESC8504 ESC8504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sammy-sandhu sammy-sandhu merged commit 96a22b3 into dev Aug 19, 2025
2 checks passed
@sammy-sandhu sammy-sandhu deleted the code-migrations branch August 19, 2025 13:42
sammy-sandhu added a commit that referenced this pull request Aug 19, 2025
* adding accordion for derived courses

* course id page

* updated workflow

* Modified workflow/added Sonarcloud config

* Removed test branch

* Derived courses initial UI setup

* spacing fixed

* took padding for accordion to match wireframe

added showMore flag

* show section only if derived courses data exists

* show more button and implementation

* Update [courseId].js

made changes to show/hide courses button to match wireframe design

* Removed dev branch from github actions (#112)

* Fixing Lint for Ironbank

* Update cd-workflows.yml

* XDS-UI Env Var Github Actions (#116)

* adding env for backend connection test

* Removed .env

* adding backend secret to workflow for backend connection test

* adding backend secret to workflow for backend connection test

* adding backend secret to workflow for backend connection test

* environment variables actions testing

* environment variables actions testing

* Cleaning up workflow/Dockerfile

* Cleaning up workflow/Dockerfile

* notifications

* rerender on mark all as read click

* fix spelling

* Update cd-workflows.yml

* Update Dockerfile to trigger workflow

* Update cd-workflows.yml

* reduce width on derived courses
have derived courses link to that course page

* change timestamp format

* adding platform to xAPI

* Correction platform in xAPI

* Edited platform

* icon css to position horizontal

* updating the hidden derived courses to a clickable link

* endpoints updated

* Mark all read button functionality update

* adding a check for no filters

* Update cd-workflows.yml

updating actions workflow trigger on dev branch

* Update README.md

* logo dynamic with config image (#120)

* updates to course information mapping

* node version update

* Updated ECR tag

* adding check

* Use xAPI Forwarding (#131)

* drop in new xapi code and tests alongside old

* feed course url to share btn

* instrument share button with shared learning resource

* remove xapi instrumentation from view button

* remove xapi instrumentation from course spotlight card

* remove xapi instrumentation from searchresult card

* instrument create saved search modal with saved search statement

* added new instrumentation to save list modal

* added new instrumentation to saved modal course page

* added explored instrumentation to course page

* expanded test for course page

* fix index test

* added search instrumentation to index page

* remove instrumentation from list page

* fix one test in search

* migrated search to new instrumentation

* rip out old instrumentation

* fix header test

* fixed default layout test

* fix final failing test why not

* refactor xAPi mock

* mock specific xapi events and migrate tests

* further refactor

* test expectation of saved

* add negative case too

* update test for index search

* Latest code sync with P1 master (#133)

* Latest code sync with P1 master

* Adding dev branch for workflow PR run

---------

Co-authored-by: Simeranjeet Sandhu <simeransandhu@deloitte.com>

* Fixed Lint

---------

Co-authored-by: schittlur <schittlur@deloitte.com>
Co-authored-by: Simeranjeet Sandhu <simeransandhu@deloitte.com>
Co-authored-by: RyanKingDeloitte <144351041+RyanKingDeloitte@users.noreply.github.com>
Co-authored-by: schittlur <78377530+schittlur@users.noreply.github.com>
Co-authored-by: Luis Reyes Madrid <lreyesmadrid@deloitte.com>
Co-authored-by: JDTobin <90791836+JDTobin@users.noreply.github.com>
Co-authored-by: kjijo <kjijo@deloitte.com>
Co-authored-by: Milton Reder <milton.reder@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants