Skip to content

[Bugfix] fix ServiceSpecificationProfileEnum values for 3.0 and 3.1#529

Closed
sebbader-sap wants to merge 26 commits intoIDTA-01002-3-1_finalfrom
IDTA-01001-3-1-2_working
Closed

[Bugfix] fix ServiceSpecificationProfileEnum values for 3.0 and 3.1#529
sebbader-sap wants to merge 26 commits intoIDTA-01002-3-1_finalfrom
IDTA-01001-3-1-2_working

Conversation

@sebbader-sap
Copy link
Copy Markdown
Contributor

@sebbader-sap sebbader-sap commented Feb 7, 2026

relates to #526

Rudra-sandeep and others added 20 commits May 27, 2025 20:03
* Remove redundant Regex Patterns (#479)

* remove redundant patterns
* add changelog entry

* formatting of list (#480)

* Added missing 404 return code (#476)

* replace explanation in the PostAllAssetLinksByID detail table

* declare assetlink/name and assetlink/value as required in openapi

* upgraded semanticIds to v3.1

* add changelog for new 404 (#483)

* add 204 for delete thumbnails, mark 200 as deprecated

* adding missing service specification profiles and fixing the example

* add missing entries also in swagger

* correct copy-paste error in subsection title

* Update documentation/IDTA-01002-3/modules/ROOT/pages/specification/interfaces.adoc

Co-authored-by: Birgit Boss <59824205+BirgitBoss@users.noreply.github.com>

* fix PostAllAssetLinksById explanation

* push all semantic IDs to V3.1

* Update README.md (#493)

* update index.adoc with version info and date (#492)

* update index.adoc with version info and date

* fix referenced security document version

---------

Co-authored-by: sebbader-sap <107036549+sebbader-sap@users.noreply.github.com>

* Update version

* Version update to 3.1.1 (#494)

---------

Co-authored-by: Birgit Boss <59824205+BirgitBoss@users.noreply.github.com>
Co-authored-by: Alexander Gordt <100141498+alexgordtop@users.noreply.github.com>
Co-authored-by: juileetikekar <juilee.tikekar@idtwin.org>
Co-authored-by: juileetikekar <99317579+juileetikekar@users.noreply.github.com>
Add the 'ServerNotImplemented' Status Code
…rationShellById

Add Parameter "id" and a new Note to PutAssetAdministrationShellById
* add link to GetFileByPath

* SerializationFormat: remove mentioning of AML, RDF because not (yet contained)
+ outlook that enum may be extended in future releases

* formatting of table for Submodel Interface

* correct link .adoc instead of html

* correct formatting of constraint AASa-003 + update links to V3-1 for Part 1 and 2
* add note for the operation GenerateSerializationByIds

* Update documentation/IDTA-01002-3/modules/ROOT/pages/specification/interfaces.adoc

Co-authored-by: Birgit Boss <59824205+BirgitBoss@users.noreply.github.com>

---------

Co-authored-by: Birgit Boss <59824205+BirgitBoss@users.noreply.github.com>
Co-authored-by: Birgit Boss <59824205+BirgitBoss@users.noreply.github.com>
Co-authored-by: Birgit Boss <59824205+BirgitBoss@users.noreply.github.com>
Co-authored-by: Birgit Boss <59824205+BirgitBoss@users.noreply.github.com>
Co-authored-by: Birgit Boss <59824205+BirgitBoss@users.noreply.github.com>
Co-authored-by: Birgit Boss <59824205+BirgitBoss@users.noreply.github.com>
@sebbader-sap sebbader-sap added this to the 3.1.2 milestone Feb 7, 2026
Copy link
Copy Markdown
Contributor

@g1zzm0 g1zzm0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Feb 27, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

✅ BirgitBoss
✅ sebbader-sap
✅ Martin187187
❌ Rudra-sandeep
You have signed the CLA already but the status is still pending? Let us recheck it.

@BirgitBoss
Copy link
Copy Markdown
Collaborator

BirgitBoss commented Mar 25, 2026

should this really be merged to https://github.com/admin-shell-io/aas-specs-api/tree/IDTA-01002-3-1_final?

Martin187187 and others added 2 commits March 29, 2026 15:05
* fixed grammar

* update changelog

* align with secuity spec

* fix patterns

* adjust datetime & time pattern

* update changelog

* fix modelstringpattern in api

* align time pattern to api

* align time pattern to api

* added missing parantheses

* fix additional bugs

* fix typo in changelog

---------

Co-authored-by: sebbader-sap <107036549+sebbader-sap@users.noreply.github.com>
@sebbader-sap
Copy link
Copy Markdown
Contributor Author

PR title is wrong, the fix for the ServiceSpecificationProfileEnum is already in the IDTA-01001-3-1-2_working. Closing this one now and opening a new PR for the v3.1.2 bugfix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants