BUGFIX Grammar 3-1-2#549
Merged
sebbader-sap merged 13 commits intoadmin-shell-io:IDTA-01001-3-1-2_workingfrom Mar 29, 2026
Merged
BUGFIX Grammar 3-1-2#549sebbader-sap merged 13 commits intoadmin-shell-io:IDTA-01001-3-1-2_workingfrom
sebbader-sap merged 13 commits intoadmin-shell-io:IDTA-01001-3-1-2_workingfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
documentation/IDTA-01002-3/modules/ROOT/partials/bnf/grammar.bnf
Dismissed
Show dismissed
Hide dismissed
Merged
Collaborator
Author
|
There is currently a problem in the combined schema and BNF files regarding attributes. An attribute is a value that can be used as an operand in logical expressions inside the Access Control, but not in the Query Language. Because the BNF and JSON schema are combined, it is currently not possible to satisfy both constraints. I need input on how we should proceed. Should we just leave it as it is? 
|
Martin187187
requested review from
BirgitBoss,
alexgordtop,
aorzelskiGH,
danielporta,
g1zzm0,
mjacoby,
sebbader-sap,
waltersve and
zrgt
as code owners
documentation/IDTA-01002-3/modules/ROOT/pages/changelog.adoc
Dismissed
Show dismissed
Hide dismissed
documentation/IDTA-01002-3/modules/ROOT/pages/changelog.adoc
Dismissed
Show dismissed
Hide dismissed
documentation/IDTA-01002-3/modules/ROOT/partials/query-json-schema.json
Dismissed
Show dismissed
Hide dismissed
BirgitBoss
reviewed
Mar 24, 2026
|
|
||
| <UseACL> ::= | ||
| "USEACLS" <ws> <StringLiteral> <ws> | ||
| "USEACL" <ws> <StringLiteral> <ws> |
Collaborator
There was a problem hiding this comment.
why singular, it is also USEFORMULAS, no? Examples in Annex seem not to be updated yet?
BirgitBoss
approved these changes
Mar 24, 2026
Collaborator
BirgitBoss
left a comment
BirgitBoss
left a comment
There was a problem hiding this comment.
I approve, although it seems to be the examples in annex are not yet fixed (USEACLS etc.). It is not clear to me why USEACLS is now singular.
sebbader-sap
merged commit de35c75
into
admin-shell-io:IDTA-01001-3-1-2_working
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #547
This Pull Request solves the following:
fixed bugs: