This repository was archived by the owner on Apr 4, 2025. It is now read-only.
feat: Telephone as a OOTB decorated component with type tel#172
Open
TalmizAhmed wants to merge 12 commits intomainfrom
Open
feat: Telephone as a OOTB decorated component with type tel#172TalmizAhmed wants to merge 12 commits intomainfrom
TalmizAhmed wants to merge 12 commits intomainfrom
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
nit23uec
suggested changes
Sep 18, 2024
nit23uec
left a comment
There was a problem hiding this comment.
as discussed, pls implement it as OOTB component
nit23uec
reviewed
Sep 25, 2024
|
this won't work until the cc is released |
vdua
reviewed
Feb 20, 2025
|
@TalmizAhmed update test url and fix the test cases. |
added 2 commits
March 18, 2025 11:59
ravise5
previously approved these changes
Mar 18, 2025
|
@TalmizAhmed have you checked if latest core-components support tel fieldtype now? |
Author
|
@ravise5 Yes the changes are a part of core-forms-components-reactor-1.1.54. |
Author
|
@ravise5 Here is the runtime with the Telephone as type: https://author-p107005-e259333-cmstg.adobeaemcloud.com/content/forms/af/telephone-test.html?ref=ue-telephone |
ravise5
previously approved these changes
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #
Test URLs: