This repository was archived by the owner on Apr 4, 2025. It is now read-only.
Open
Conversation
lovelymandal16
requested review from
TalmizAhmed,
nit23uec,
ravise5 and
ujjwal5
|
@lovelymandal16 can you add the url for testing, need to verify few things. |
ravise5
reviewed
Feb 27, 2025
| const maxItems = (parseInt(input.dataset.maxItems, 10) || -1); | ||
| const fileSize = `${input.dataset.maxFileSize || '2MB'}`; | ||
| let constraint = ''; | ||
| let constraintErrorMessage = ''; |
There was a problem hiding this comment.
@lovelymandal16 why do we need 2 variables constraint and constraintErrorMessage ? both seem to be storing the constraint here.
ravise5
reviewed
Mar 18, 2025
| if (constraint.length) { | ||
| const finalMessage = wrapper.dataset[constraint] | ||
| const finalMessage = wrapper.dataset[constraintErrorMessage] | ||
| || errorMessage |
There was a problem hiding this comment.
Can't we replace this with ${constraint}ErrorMessge ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
URL for testing : https://author-p133911-e1313554.adobeaemcloud.com/content/forms/af/setup3-lovely.html
Fix #FORMS-14814
Test URLs: