Skip to content

Add CodeQL configuration#3002

Merged
afranken merged 1 commit intomainfrom
fix-codeql-action-ctd
Mar 20, 2026
Merged

Add CodeQL configuration#3002
afranken merged 1 commit intomainfrom
fix-codeql-action-ctd

Conversation

@afranken
Copy link
Member

Description

Let's hope that this fixes the Github backend.

Related Issue

N/A

Tasks

  • I have signed the CLA.
  • I have written tests and verified that they fail without my change.
  • I have run make format to fix code style.
  • I have updated CHANGELOG.md (if applicable).
  • I have updated documentation (if applicable).

Let's hope that this fixes the Github backend.
Copilot AI review requested due to automatic review settings March 20, 2026 17:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a GitHub Actions CodeQL workflow to enable code scanning for the repository’s Java/Kotlin code, intended to improve/restore GitHub code-scanning behavior.

Changes:

  • Introduces a new .github/workflows/codeql.yml workflow that runs CodeQL on pushes and PRs to main and s3mock-v2/v3/v4.
  • Configures CodeQL initialization with security-extended queries and uses setup-java + CodeQL autobuild.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

fail-fast: false
matrix:
language: [ 'java-kotlin' ]
# CodeQL supports [ 'cpp', 'csharp', 'go', 'java', 'javascript', 'python', 'ruby' ]
Copy link

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The inline comment about supported CodeQL languages is misleading here: it omits java-kotlin, which is the language actually configured in the matrix. Please update the comment (or remove it) to avoid implying java-kotlin is unsupported.

Suggested change
# CodeQL supports [ 'cpp', 'csharp', 'go', 'java', 'javascript', 'python', 'ruby' ]
# CodeQL supports [ 'cpp', 'csharp', 'go', 'java', 'java-kotlin', 'javascript', 'python', 'ruby' ]

Copilot uses AI. Check for mistakes.
Comment on lines +43 to +50
steps:
- name: Harden Runner
uses: step-security/harden-runner@fa2e9d605c4eeb9fcad4c99c224cee0c6c7f3594 # v2.16.0
with:
egress-policy: audit

- name: Checkout repository
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
Copy link

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

steps: is indented correctly, but the list items are not. In GitHub Actions YAML, each step entry must be indented under steps: (e.g., steps: then - name: ...). As written, this file is invalid YAML and the workflow will fail to load/run.

Copilot uses AI. Check for mistakes.
@afranken afranken merged commit f1b0187 into main Mar 20, 2026
11 checks passed
@afranken afranken deleted the fix-codeql-action-ctd branch March 20, 2026 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants