XMPFiles/source/XMPFiles_Impl.cpp: fix arm build with gcc 10#57
Open
ffontaine wants to merge 1 commit intoadobe:mainfrom
Open
XMPFiles/source/XMPFiles_Impl.cpp: fix arm build with gcc 10#57ffontaine wants to merge 1 commit intoadobe:mainfrom
ffontaine wants to merge 1 commit intoadobe:mainfrom
Conversation
Fix the following build failure with exempi on arm with gcc 10 raised since version 2.6.0 and https://gitlab.freedesktop.org/libopenraw/exempi/-/commit/0872e35a30457d2ecf746a1bebdb7d94636d0e2f adobe@0872e35: /home/giuliobenetti/autobuild/run/instance-3/output-1/host/lib/gcc/arm-buildroot-linux-uclibcgnueabi/10.3.0/../../../../arm-buildroot-linux-uclibcgnueabi/bin/ld: ../../XMPFiles/source/.libs/libXMPFiles.a(XMPFiles_Impl.o):(.rodata+0x5c): multiple definition of `typeinfo name for TXMPMeta<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >'; XMPFilesCoverage.o:(.rodata+0x0): first defined here More information can be found on a similar issue here: OpenKinect/libfreenect2#157 Fixes: - http://autobuild.buildroot.org/results/c440719de02a154c6bdae11bda06ea30c131c71d Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
|
Issue also occur on gcc 9.3.0 |
jollaitbot
pushed a commit
to sailfishos-mirror/exempi
that referenced
this pull request
Dec 10, 2022
Cherry-pick adobe/XMP-Toolkit-SDK#57 Original commit messsage: ========== Author: Fabrice Fontaine <fontaine.fabrice@gmail.com> XMPFiles/source/XMPFiles_Impl.cpp: fix arm build with gcc 10 Fix the following build failure with exempi on arm with gcc 10 raised since version 2.6.0 and https://gitlab.freedesktop.org/libopenraw/exempi/-/commit/0872e35a30457d2ecf746a1bebdb7d94636d0e2f adobe/XMP-Toolkit-SDK@0872e35: /home/giuliobenetti/autobuild/run/instance-3/output-1/host/lib/gcc/arm-buildroot-linux-uclibcgnueabi/10.3.0/../../../../arm-buildroot-linux-uclibcgnueabi/bin/ld: ../../XMPFiles/source/.libs/libXMPFiles.a(XMPFiles_Impl.o):(.rodata+0x5c): multiple definition of `typeinfo name for TXMPMeta<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >'; XMPFilesCoverage.o:(.rodata+0x0): first defined here More information can be found on a similar issue here: OpenKinect/libfreenect2#157 Fixes: - http://autobuild.buildroot.org/results/c440719de02a154c6bdae11bda06ea30c131c71d Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> ========== Signed-off-by: Hubert Figuière <hub@figuiere.net>
|
Hello! I've faced the same problem on arm32v7/ubuntu docker container and on Raspberry Pi OS 32-bit. I fixed the source code of XMPFiles_Impl.cpp according to the fixes provided by hfiguiere and now it works fine, thank you! Can you please review this code and merge it to main? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix the following build failure with exempi on arm with gcc 10 raised since version 2.6.0 and https://gitlab.freedesktop.org/libopenraw/exempi/-/commit/0872e35a30457d2ecf746a1bebdb7d94636d0e2f and 0872e35:
More information can be found on a similar issue here: OpenKinect/libfreenect2#157
Fixes:
Related Issue
Motivation and Context
This change is needed to avoid build failure with exempi: http://autobuild.buildroot.org/?reason=exempi-2.6.1
How Has This Been Tested?
This has been build-tested with buidlroot.
Screenshots (if appropriate):
Types of changes
Checklist: