-
Notifications
You must be signed in to change notification settings - Fork 65
FORMS-18631: Desktop, RWD Tablet, RWD Mobile - Grid: Grid is missing appropriate roles and/or attributes @sunnym @vavarshn #1740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
CezarSTF
wants to merge
2
commits into
dev
Choose a base branch
from
ens83070/FORMS-18631
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
ui.af.apps/src/main/content/jcr_root/apps/core/fd/components/form/datepicker/v2/.content.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <jcr:root xmlns:jcr="http://www.jcp.org/jcr/1.0" xmlns:nt="http://www.jcp.org/jcr/nt/1.0" | ||
| jcr:primaryType="nt:unstructured"> | ||
| <datepicker/> | ||
| </jcr:root> |
8 changes: 8 additions & 0 deletions
8
.../main/content/jcr_root/apps/core/fd/components/form/datepicker/v2/datepicker/.content.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <jcr:root xmlns:sling="http://sling.apache.org/jcr/sling/1.0" xmlns:cq="http://www.day.com/jcr/cq/1.0" xmlns:jcr="http://www.jcp.org/jcr/1.0" | ||
| cq:icon="date" | ||
| jcr:description="Add a field with a calendar widget to select a date." | ||
| jcr:primaryType="cq:Component" | ||
| jcr:title="Adaptive Form Date Picker (v2)" | ||
| sling:resourceSuperType="core/fd/components/form/base/v1/base" | ||
| componentGroup=".core-adaptiveform"/> | ||
100 changes: 100 additions & 0 deletions
100
...ontent/jcr_root/apps/core/fd/components/form/datepicker/v2/datepicker/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,100 @@ | ||
| <!-- | ||
| Copyright 2025 Adobe | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| --> | ||
| Adaptive Form Date Picker (v2) | ||
| ==== | ||
| Adaptive Form Date Picker field component written in HTL. | ||
|
|
||
| ## Features | ||
|
|
||
| * Provides the following type of input: | ||
| * date | ||
| * Allows replacing this component with other component (as mentioned below). | ||
|
|
||
| ### Use Object | ||
| The Form Date Picker component uses the `com.adobe.cq.forms.core.components.models.form.DatePicker` Sling Model for its Use-object. | ||
|
|
||
| ### Edit Dialog Properties | ||
| The following properties are written to JCR for this Form Date component and are expected to be available as `Resource` properties: | ||
|
|
||
| 1. `./jcr:title` - defines the label to use for this field | ||
| 2. `./hideTitle` - if set to `true`, the label of this field will be hidden | ||
| 3. `./name` - defines the name of the field, which will be submitted with the form data | ||
| 4. `./default` - defines the default value of the field | ||
| 5. `./description` - defines a help message that can be rendered in the field as a hint for the user | ||
| 6. `./required` - if set to `true`, this field will be marked as required, not allowing the form to be submitted until the field has a value | ||
| 7. `./requiredMessage` - defines the message displayed as tooltip when submitting the form if the value is left empty | ||
| 8. `./readOnly` - if set to `true`, the filed will be read only | ||
| 9. `./dataFormat` - defines the format in which the value exported/submitted | ||
| 10. `./editFormat` - defines the format in which the value will be edited by the user | ||
| 11. `./minimumDate` - define the minimum date input allowed for the field | ||
| 12. `./maximumDate` - define the maximum date input allowed for the field | ||
| 13. `./displayFormat` - define the template for display pattern (Reference can be found [here](https://unicode.org/reports/tr35/tr35-dates.html#Date_Format_Patterns)). | ||
|
|
||
| ## Client Libraries | ||
| The component provides a `core.forms.components.datePicker.v2.runtime` client library category that contains the Javascript runtime for the component. | ||
| It should be added to a relevant site client library using the `embed` property. | ||
|
|
||
| ## BEM Description | ||
| ``` | ||
| BLOCK cmp-adaptiveform-datepicker | ||
| ELEMENT cmp-adaptiveform-datepicker__label | ||
| ELEMENT cmp-adaptiveform-datepicker__label-container | ||
| ELEMENT cmp-adaptiveform-datepicker__widget | ||
| ELEMENT cmp-adaptiveform-datepicker__questionmark | ||
| ELEMENT cmp-adaptiveform-datepicker__shortdescription | ||
| ELEMENT cmp-adaptiveform-datepicker__longdescription | ||
| ELEMENT cmp-adaptiveform-datepicker__errormessage | ||
| ``` | ||
|
|
||
| ### Note | ||
| By placing the class names `cmp-adaptiveform-datepicker__label` and `cmp-adaptiveform-datepicker__questionmark` within the `cmp-adaptiveform-datepicker__label-container` class, you create a logical grouping of the label and question mark elements. This approach simplifies the process of maintaining a consistent styling for both elements. | ||
|
|
||
| ## JavaScript Data Attribute Bindings | ||
|
|
||
| The following attributes must be added for the initialization of the date-picker component in the form view: | ||
| 1. `data-cmp-is="adaptiveFormDatePicker"` | ||
| 2. `data-cmp-adaptiveformcontainer-path="${formstructparser.formContainerPath}"` | ||
|
|
||
|
|
||
| The following are optional attributes that can be added to the component in the form view: | ||
| 1. `data-cmp-valid` having a boolean value to indicate whether the field is currently valid or not | ||
| 2. `data-cmp-required` having a boolean value to indicate whether the field is currently required or not | ||
| 3. `data-cmp-readonly` having a boolean value to indicate whether the field is currently readonly or not | ||
| 4. `data-cmp-active` having a boolean value to indicate whether the field is currently active or not | ||
| 5. `data-cmp-visible` having a boolean value to indicate whether the field is currently visible or not | ||
| 6. `data-cmp-enabled` having a boolean value to indicate whether the field is currently enabled or not | ||
|
|
||
| ## Replace feature: | ||
| We support replace feature that allows replacing Reset Button component to any of the below components: | ||
|
|
||
| * Button | ||
| * Email Input | ||
| * Number Input | ||
| * Reset Button | ||
| * Submit Button | ||
| * Telephone Input | ||
| * Text Box | ||
| * Text Input | ||
|
|
||
|
|
||
| ## Information | ||
| * **Vendor**: Adobe | ||
| * **Version**: v2 | ||
| * **Compatibility**: Cloud | ||
| * **Status**: production-ready | ||
|
|
||
|
|
||
|
|
3 changes: 3 additions & 0 deletions
3
...nt/jcr_root/apps/core/fd/components/form/datepicker/v2/datepicker/clientlibs/.content.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <jcr:root xmlns:sling="http://sling.apache.org/jcr/sling/1.0" xmlns:jcr="http://www.jcp.org/jcr/1.0" | ||
| jcr:primaryType="sling:Folder"/> |
6 changes: 6 additions & 0 deletions
6
...r_root/apps/core/fd/components/form/datepicker/v2/datepicker/clientlibs/site/.content.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <jcr:root xmlns:cq="http://www.day.com/jcr/cq/1.0" xmlns:jcr="http://www.jcp.org/jcr/1.0" | ||
| jcr:primaryType="cq:ClientLibraryFolder" | ||
| allowProxy="{Boolean}true" | ||
| categories="[core.forms.components.datePicker.v2.runtime]" | ||
| dependencies="[core.forms.components.runtime.base]"/> |
19 changes: 19 additions & 0 deletions
19
...nt/jcr_root/apps/core/fd/components/form/datepicker/v2/datepicker/clientlibs/site/css.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| ############################################################################### | ||
| # Copyright 2025 Adobe | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| ############################################################################### | ||
|
|
||
| #base=css | ||
| datepickerview.css | ||
| datepickerwidget.css |
45 changes: 45 additions & 0 deletions
45
...s/core/fd/components/form/datepicker/v2/datepicker/clientlibs/site/css/datepickerview.css
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| /******************************************************************************* | ||
| * Copyright 2025 Adobe | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| ******************************************************************************/ | ||
| .cmp-adaptiveform-datepicker { | ||
|
|
||
| } | ||
|
|
||
| .cmp-adaptiveform-datepicker__widget { | ||
|
|
||
| } | ||
|
|
||
| .cmp-adaptiveform-datepicker__label { | ||
|
|
||
| } | ||
| .cmp-adaptiveform-datepicker__label-container{ | ||
|
|
||
| } | ||
|
|
||
| .cmp-adaptiveform-datepicker__longdescription { | ||
|
|
||
| } | ||
|
|
||
| .cmp-adaptiveform-datepicker__shortdescription { | ||
|
|
||
| } | ||
|
|
||
| .cmp-adaptiveform-datepicker__questionmark { | ||
|
|
||
| } | ||
|
|
||
| .cmp-adaptiveform-datepicker__questionmark { | ||
|
|
||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.