Updating input components' validation field to reflect existing pattern #1785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (formatComponent && !formatComponent.closest("div").hasAttribute("hidden") && displayPatternSelectedValue!="custom") { | ||
| formatComponent.value = patternComponent.value; | ||
| // Preserve a previously saved pattern (when no dropdown options are present) | ||
| formatComponent.value = formatComponent.value || patternComponent.value; |
Contributor
There was a problem hiding this comment.
does this also impact other components? was custom format working correctly for other components custom format?
Member
Author
There was a problem hiding this comment.
This method is consumed by multiple components (textinput, telephoneinput, numberinput and datepicker) - i have tested all the components with the change added in new commit, no current functionality is broken.
muskgupta
changed the title
muskgupta
commented
Jan 9, 2026
| // Only update format component value if it exists and is not hidden | ||
| if (formatComponent && !formatComponent.closest("div").hasAttribute("hidden") && displayPatternSelectedValue!="custom") { | ||
| formatComponent.value = patternComponent.value; | ||
| // Only update format component value if it exists and is not hidden |
Member
Author
There was a problem hiding this comment.
We will update the pattern value from dropdown only in cases where dropdown is visible. Earlier it was updating even on manual pattern entry where the dropdown was not visible and the pattern dropdown had value "" which was rewriting the entered format value from showing up subsequently in the dialog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating textinput core component's validation field to reflect existing pattern if entered.
Customer : Suncorp
Related Issue
E-001967925
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: