Skip to content

Add id to the outer div#143

Open
pavi41 wants to merge 1 commit intomainfrom
vanilla/add-id
Open

Add id to the outer div#143
pavi41 wants to merge 1 commit intomainfrom
vanilla/add-id

Conversation

@pavi41
Copy link
Contributor

@pavi41 pavi41 commented Jun 12, 2024

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Collaborator

@rismehta rismehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you confirm that the HTML structure align with the core component markup (please check other attributes/structure other than id), please cross check once, https://github.com/adobe/aem-core-forms-components

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants