Skip to content

FORMS-13861 removed default description from DatePicker, maintining b… #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
barshat7 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

FORMS-13861 removed default description from DatePicker, maintining b… #144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/react-vanilla-components/src/components/DateInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,10 @@ import { withRuleEngine } from '../utils/withRuleEngine';
import { PROPS } from '../utils/type';
import FieldWrapper from './common/FieldWrapper';
import { syncAriaDescribedBy } from '../utils/utils';
import { formatDate } from '@aemforms/af-formatters';

const DateInput = (props: PROPS) => {
const { id, label, value, required, name, readOnly, placeholder, visible, enabled, appliedCssClassNames, valid } = props;
const { id, label, value, required, name, readOnly, placeholder, visible, enabled, appliedCssClassNames, valid, editFormat } = props;
const finalValue = value === undefined ? '' : value;

const changeHandler = useCallback((e: React.ChangeEvent<HTMLInputElement>) => {
Expand All @@ -40,6 +41,10 @@ const DateInput = (props: PROPS) => {
props.dispatchBlur();
}, [props.dispatchBlur]);

const locale = new Intl.DateTimeFormat().resolvedOptions().locale;
Copy link
Collaborator

@rismehta rismehta Jul 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to access locale from the current context, its part of the model

Copy link
Collaborator

@rismehta rismehta Jul 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We expose lang in field state, could you try using that instead ?


const defaultDescription = `To enter today's date use ${formatDate(new Date(), locale, editFormat)}`;

return (
<div
className={`cmp-adaptiveform-datepicker cmp-adaptiveform-datepicker--${value ? 'filled' : 'empty'} ${appliedCssClassNames || ''}`}
Expand All @@ -54,7 +59,7 @@ const DateInput = (props: PROPS) => {
label={label}
id={id}
tooltip={props.tooltip}
description={props.description}
description= {props.description ? props.description : defaultDescription}
isError={props.isError}
errorMessage={props.errorMessage}
>
Expand Down