Closed
Conversation
rismehta
reviewed
Aug 25, 2025
| const newFiles = Array.from<File>(e.dataTransfer?.files || e?.target?.files || e.clipboardData?.files || []); | ||
|
|
||
| // Clear the input value to allow re-uploading the same file again | ||
| if (e.target && e.target.type === 'file') { |
Collaborator
There was a problem hiding this comment.
We can upload multiple files at once as well, I don't think that use-case is handled here.
Collaborator
Author
There was a problem hiding this comment.
Sir multiple files upload use case was already handled before, the 2 main issues which we were experiencing was re-uploading the removed file and uploading 2 files having same name.
the use case achieved.
| onClick={(e) => { | ||
| // Prevent form submit bubbling when used inside a <form> | ||
| e.preventDefault(); | ||
| e.stopPropagation(); |
There was a problem hiding this comment.
should be prevented at form level
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: File Upload Re-upload Issue
Description
This PR fixes a critical bug in the FileUpload component where users could not re-upload the same file after removing it. Another was to support the file upload feature in which the user can upload multiple files with same name.
Key Changes:
Related Issue
Motivation and Context
How Has This Been Tested?
Unit Tests Added:
should allow re-uploading same file after removal- Tests the core bug fixshould handle duplicate filenames correctly without removing wrong file- Tests improved file tracking with UIDsManual Testing:
Screenshots (if appropriate):
Types of changes
Checklist: