define explicit compile scope for slf4j in it-tests

[bisswanger]

The slf4j dependency is required as a compile-level artifact for it.tests.
it.tests are bundled into a jar-with-dependencies and then passed to the testing service during a pipeline execution

We have seen that customers are updating slf4j versions and then the config from the main pom.xml may take effect and the slf4j classes excluded - this then leads to pipeline failures

aem-project-archetype/src/main/archetype/pom.xml

Lines 719 to 724 in 410ca40

	<dependency>
	<groupId>org.slf4j</groupId>
	<artifactId>slf4j-simple</artifactId>
	<version>1.7.25</version>
	<scope>test</scope>
	</dependency>

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• I have signed the Adobe Open Source CLA.
• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.