Skip to content

Conversation

@shazron
Copy link
Member

@shazron shazron commented Aug 1, 2025

Description

https://jira.corp.adobe.com/browse/ACNA-3953

Activity logs for extensions were not showing up:

  1. start of deploy
  2. start of undeploy
  3. web assets deployed
  4. web assets undeployed

For standalone apps, the activity logs were fine.

How Has This Been Tested?

  • aio app deploy for a project with an extension, e.g Experience Cloud Shell extension
  • aio app deploy for a standalone project (--stand-alone)
  • aio app deploy with a technical account credential
  • All relevant logs including the missing ones should show up in the project's Activity Log

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Aug 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (a2922db) to head (6e8c2ba).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #878   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           57        57           
  Lines         3265      3265           
  Branches       631       631           
=========================================
  Hits          3265      3265           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@pru55e11 pru55e11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shazron shazron merged commit 1ad330e into master Aug 4, 2025
10 checks passed
@shazron shazron deleted the story/ACNA-3953 branch August 4, 2025 13:19
purplecabbage pushed a commit that referenced this pull request Nov 10, 2025
* fix: getting cached access token returns undefined
* add failing tests
* fix getAccessToken failing test for --no-publish and --no-unpublish (logic error)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants