Split packages/core into packages/core and packages/browser by carterworks · Pull Request #1411 · adobe/alloy

carterworks · 2025-12-05T22:29:35Z

Warning

~~This PR is based off of #1414, which itself is based off of #1412, so this should not be merged until they are.~~

Description

This PR changes the publishing artifact from being the packages/core folder to a new folder called packages/browser. And that folder gets the @adobe/alloy, and then the core folder appropriately gets the name @adobe/alloy-core. The intent is that both of these packages will be published to NPM.

The core package will be buildless, and then all build steps as well as integration and functional tests, anything to do with a browser stays in the browser package.

No functionality or browser specific functionality has been removed from the packages, the core package, but that is kind of the next step, and hopefully that work can be parallelized.

~~As it stands right now, the CI test and the publishing workflow still need to be completed. But right now this branch is 95% done.~~

Related Issue

Motivation and Context

Screenshots (if appropriate):

Checklist:

I have signed the Adobe Open Source CLA or I'm an Adobe employee.
I have made any necessary test changes and all tests pass.
I have run the Sandbox successfully.

changeset-bot · 2026-01-23T19:35:37Z

⚠️ No Changeset found

Latest commit: 02f6385

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

carterworks · 2026-01-23T20:28:48Z

Current test failures are related to queueTimeMillis and are unrelated, maybe.

So we are ready to merge.

jonsnyder · 2026-01-27T18:23:01Z

Let's merge this after the release.

# Conflicts: # package.json # packages/browser/test/integration/helpers/mocks/emptyEventResponse.json # packages/browser/test/integration/helpers/mocks/mediaSessionResponse.json # packages/browser/test/integration/helpers/mocks/targetCustomCodeAction.json # packages/browser/test/integration/helpers/mocks/targetPrependHtmlAction.json # packages/browser/test/integration/specs/Advertising/consent_gate.spec.js # packages/core/package.json # packages/core/test/unit/specs/components/Advertising/handlers/viewThroughHandler.spec.js

# Conflicts: # package.json # packages/browser/test/integration/specs/Advertising/clickthrough_duplicate_skwcid.spec.js

packages/browser/package.json

packages/browser/src/standalone.js

dompuiu · 2026-02-23T23:14:49Z

packages/core/src/componentMetadata.js

+OF ANY KIND, either express or implied. See the License for the specific language
+governing permissions and limitations under the License.
+*/
+import fs from "fs";


I find it a little weird that in a file from src we are using Node APIs. If this file would be read by a bundler, it might crash. What do you think?

It's actually the other way around - rollup polyfils calls to fs, so if it is called by the browser then it will crash.

It is looking more and more likely that I need to abandon the goal of being buildless.

You and I talked in person and discovered that the functionality of componentMetadata.js can be moved into the alloyBuilder, because that is the only place that it is used.

do that

dompuiu · 2026-02-23T23:54:42Z

packages/core/src/createEventListeners.js

+          await makeSendServiceWorkerTrackingData(
+            {
+              /* eslint-disable-next-line no-underscore-dangle */
+              xdm: data._xdm.mixins,


Will data always have an _xdm key?

It's just a copy-paste from your serviceWorker.js file, so it will depend on what gets attached to notificationclose service worker events, as it did before.

See:

alloy/packages/core/src/serviceWorker.js

Line 77 in 366cc96

makeSendServiceWorkerTrackingData(

alloy/packages/browser/src/serviceWorker.js

Lines 79 to 80 in 02f6385

sw.addEventListener("notificationclose", (event) => {

eventListeners.pushNotifications.onNotificationClose(event);

alloy/packages/core/src/createEventListeners.js

Line 52 in 02f6385

async onNotificationClose(event) {

dompuiu · 2026-02-24T00:00:27Z

packages/core/src/createEventListeners.js

+       * @param {NotificationEvent} event
+       */
+      onNotificationClick(event) {
+        serviceWorkerNotificationClickListener({


onPush returns a listener while onNotificationClick returns undefined. Should we return here too?

dompuiu · 2026-02-24T00:04:42Z

There is something wrong with the linting. Running pnpm run lint doesn't show any errors. But if you open the file packages/browser/scripts/helpers/entryPointGeneratorBabelPlugin.js, you should see prettier errors (I tested in nvim and vscode).

dompuiu · 2026-02-24T21:20:18Z

packages/browser/package.json

+    "build:clean": "rimraf dist distTest",
+    "build:types": "tsc -p jsconfig.json --declaration --emitDeclarationOnly --outDir dist/types --checkJs false --noEmit false",
+    "build": "pnpm run build:clean && rollup -c --environment BASE_CODE_MIN,STANDALONE,STANDALONE_MIN,SERVICE_WORKER,SERVICE_WORKER_MIN,BUNDLESIZE && pnpm run build:types",
+    "build:watch": "rollup -c --watch",


The build:watch doesn't work

dompuiu · 2026-02-24T21:22:12Z

How do you run the dev command now that was removed from the root package.json?

dompuiu · 2026-02-24T21:24:55Z

In rollup.config.js there are some typos: brotili instead of brotli.

carterworks self-assigned this Dec 5, 2025

carterworks added the ignore-for-release Do not include this PR in release notes label Dec 5, 2025

carterworks added 28 commits December 11, 2025 20:35

Create a licensing eslint plugin

42de451

Convert license inclusion script to eslint plugin

cae54e8

Use the license_banner for the eslint plugin.

c2e02ff

Delete old file

2a3b73f

Make rule instead of plugin

e880a5f

Run the plugin

81233f8

Fix files with typos in license header

77eb670

Fix a case where there is no new line after shebang

4821606

Integrate changesets

43512f1

Add changeset file

b6613ef

Add some sanity checks to the url

ba4dba9

Add some sanity checks to the CDN upload

d3e88ce

Init browser package

fc98dbb

Move baseCode and index to browser package

ac5c52d

Migrate service worker

da1d61a

Migrate standalone.js

c480377

Migrate the build

d84e101

Migrate integration tests

5db6039

Move functional tests into browser package

08fc3db

Delete unused top level files

1fa494b

Move alloyBuilder

3f1590f

Reorganize dependencies

b905d3d

Delete duplicated functional tests

d9d0fb1

Add some subpackage scripts that refer to root package scripts

f1fcf93

Add missing scripts dependencies

cd7bbf1

Fix custom build

91afb46

change npm_package env label to functional_test, fix functional tests

6f1a467

Fix a small issue in the service worker

6a31f56

carterworks and others added 4 commits January 7, 2026 16:04

Be consistent in .browserslistrc definition

682a69a

Add some extra types.

e109bcc

Some more types.

4506e8a

Merge branch 'main' into create-browser-package

2f474d9

carterworks added 2 commits January 23, 2026 12:38

Fix lockfile

c6219f7

Fix sandbox build issue

3b85575

jonsnyder marked this pull request as draft January 27, 2026 18:23

carterworks added 6 commits February 10, 2026 10:35

chore: move new tests

1cb1a97

chore: update bundlesize.json

6471964

fix: make unit tests a little more resilient

c36ba7c

Merge remote-tracking branch 'origin/main' into create-browser-package

197aed9

# Conflicts: # package.json # packages/browser/test/integration/specs/Advertising/clickthrough_duplicate_skwcid.spec.js

Merge remote-tracking branch 'origin/main' into create-browser-package

53ce197

carterworks marked this pull request as ready for review February 17, 2026 16:23

carterworks added 2 commits February 17, 2026 13:47

iterate on migration plan

e00e41d

delete migration plan

dfbf821

dompuiu reviewed Feb 23, 2026

View reviewed changes

packages/browser/package.json Show resolved Hide resolved

dompuiu reviewed Feb 23, 2026

View reviewed changes

packages/browser/src/standalone.js Show resolved Hide resolved

dompuiu reviewed Feb 23, 2026

View reviewed changes

dompuiu reviewed Feb 24, 2026

View reviewed changes

carterworks added 2 commits February 24, 2026 10:13

Add src to browser npm package

eaed6a7

Remove async from initializeStandalone

02f6385

dompuiu reviewed Feb 24, 2026

View reviewed changes

	sw.addEventListener("notificationclose", (event) => {
	eventListeners.pushNotifications.onNotificationClose(event);

Conversation

carterworks commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue

Motivation and Context

Screenshots (if appropriate):

Checklist:

Uh oh!

changeset-bot bot commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

carterworks commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jonsnyder commented Jan 27, 2026

Uh oh!

Uh oh!

Uh oh!

dompuiu Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

carterworks Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

carterworks Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dompuiu Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

carterworks Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

dompuiu Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

dompuiu commented Feb 24, 2026

Uh oh!

dompuiu Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

dompuiu commented Feb 24, 2026

Uh oh!

dompuiu commented Feb 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

carterworks commented Dec 5, 2025 •

edited

Loading

changeset-bot bot commented Jan 23, 2026 •

edited

Loading

carterworks commented Jan 23, 2026 •

edited

Loading

carterworks Feb 24, 2026 •

edited

Loading