Skip to content
This repository was archived by the owner on Sep 2, 2021. It is now read-only.

Commit 596cdcd

Browse files
committed
Merge pull request #462 from MarcelGerber/sprint-to-release
Sprint -> Release
2 parents 4f82c24 + a2aa284 commit 596cdcd

File tree

7 files changed

+34
-34
lines changed

7 files changed

+34
-34
lines changed

appshell/version.rc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ BEGIN
4343
BEGIN
4444
VALUE "CompanyName", "brackets.io\0"
4545
VALUE "FileDescription", "\0"
46-
VALUE "FileVersion", "Sprint 44\0"
46+
VALUE "FileVersion", "Release 44\0"
4747
VALUE "ProductName", APP_NAME "\0"
4848
VALUE "ProductVersion", "\0"
4949
VALUE "LegalCopyright", "(c) 2012 Adobe Systems, Inc.\0"

installer/mac/buildInstaller.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
# config
44
releaseName="Brackets"
5-
dmgName="${releaseName} Sprint 44"
5+
dmgName="${releaseName} Release 44"
66
format="bzip2"
77
encryption="none"
88
tmpLayout="./dropDmgConfig/layouts/tempLayout"
@@ -40,4 +40,4 @@ dropdmg ./$tempDir --format $format --encryption $encryption $customIcon --layou
4040

4141
# clean up
4242
rm -rf $tempDir
43-
rm -rf $tmpLayout
43+
rm -rf $tmpLayout

installer/win/README.MD

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,14 +28,14 @@ Normally, the installer scripts are run via Jenkins on the build machine http://
2828
* Copy these two files to _(wix-install-dir)_\bin
2929
9. You may need to locally edit `wix.base` in brackets-win-install-build.xml if the Wix install folder doesn't match what's hardcoded there
3030

31-
## Update Sprint Number with Grunt
32-
To rev the Brackets sprint number with Grunt, both brackets-shell and brackets repositories must be updated. For the initial Grunt setup, see: https://github.com/adobe/brackets/wiki/Grunt-Setup.
31+
## Update Release Number with Grunt
32+
To rev the Brackets release number with Grunt, both brackets-shell and brackets repositories must be updated. For the initial Grunt setup, see: https://github.com/adobe/brackets/wiki/Grunt-Setup.
3333

34-
brackets > grunt set-sprint --sprint=NN
35-
brackets-shell > grunt set-sprint --sprint=NN
34+
brackets > grunt set-release --release=NN
35+
brackets-shell > grunt set-release --release=NN
3636

37-
## To rev the Brackets sprint number manually
38-
1. Open brackets-win-install-build.xml and change `product.sprint.number`
37+
## To rev the Brackets release number manually
38+
1. Open brackets-win-install-build.xml and change `product.release.number`
3939
2. Open brackets-shell\installer\mac\buildInstaller.sh and change `releaseName`
4040
3. Open Brackets.wxs and replace the `StartMenuShortcut` GUID property with a newly generated GUID
4141
4. Open brackets-shell\appshell\version.rc and change `FILEVERSION` and `"FileVersion"`

installer/win/brackets-win-install-build.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@ default="build.mul">
1111
<!-- Product & version labeling -->
1212
<!-- See also: product name definitions in Brackets_<locale>.wxl -->
1313
<property name="product.shortname" value="Brackets"/>
14-
<property name="product.sprint.number" value="44"/>
15-
<property name="product.version.number" value="0.${product.sprint.number}"/>
16-
<property name="product.version.name" value="Sprint ${product.sprint.number}"/>
14+
<property name="product.release.number" value="44"/>
15+
<property name="product.version.number" value="0.${product.release.number}"/>
16+
<property name="product.version.name" value="Release ${product.release.number}"/>
1717
<property name="product.fullname" value="Brackets ${product.version.name}"/>
1818
<property name="product.manufacturer" value="brackets.io"/>
1919
<property name="product.registry.root" value="${product.shortname}"/>

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,4 +28,4 @@
2828
"install": "",
2929
"postinstall": "bash -c 'mv .appshell.gyp appshell.gyp;'"
3030
}
31-
}
31+
}

tasks/build.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -234,10 +234,10 @@ module.exports = function (grunt) {
234234
grunt.file.write("installer/linux/debian/package-root/DEBIAN/control", content);
235235

236236
var done = this.async(),
237-
sprint = semver.parse(grunt.config("pkg").version).minor;
237+
release = semver.parse(grunt.config("pkg").version).minor;
238238

239239
spawn(["bash build_installer.sh"], { cwd: resolve("installer/linux"), env: getBracketsEnv() }).then(function () {
240-
return common.rename("installer/linux/brackets.deb", "installer/linux/Brackets Sprint " + sprint + " " + common.arch() + "-bit.deb");
240+
return common.rename("installer/linux/brackets.deb", "installer/linux/Brackets Release " + release + " " + common.arch() + "-bit.deb");
241241
}).then(function () {
242242
done();
243243
}, function (err) {
@@ -251,10 +251,10 @@ module.exports = function (grunt) {
251251
grunt.task.requires(["package"]);
252252

253253
var done = this.async(),
254-
sprint = semver.parse(grunt.config("pkg").version).minor;
254+
release = semver.parse(grunt.config("pkg").version).minor;
255255

256256
spawn(["bash build_archive.sh"], { cwd: resolve("installer/linux"), env: getBracketsEnv() }).then(function () {
257-
return common.rename("installer/linux/brackets.tar.gz", "installer/linux/Brackets Sprint " + sprint + " " + common.arch() + "-bit.tar.gz");
257+
return common.rename("installer/linux/brackets.tar.gz", "installer/linux/Brackets Release " + release + " " + common.arch() + "-bit.tar.gz");
258258
}).then(function () {
259259
done();
260260
}, function (err) {

tasks/set-sprint.js

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -37,49 +37,49 @@ module.exports = function (grunt) {
3737
return newContent;
3838
}
3939

40-
// task: set-sprint
41-
grunt.registerTask("set-sprint", "Update occurrences of sprint number for all native installers and binaries", function () {
40+
// task: set-release
41+
grunt.registerTask("set-release", "Update occurrences of release number for all native installers and binaries", function () {
4242
var packageJsonPath = "package.json",
4343
packageJSON = grunt.file.readJSON(packageJsonPath),
4444
winInstallerBuildXmlPath = "installer/win/brackets-win-install-build.xml",
4545
buildInstallerScriptPath = "installer/mac/buildInstaller.sh",
4646
wxsPath = "installer/win/Brackets.wxs",
4747
versionRcPath = "appshell/version.rc",
4848
infoPlistPath = "appshell/mac/Info.plist",
49-
sprint = grunt.option("sprint") || 0,
49+
release = grunt.option("release") || 0,
5050
versionShort = packageJSON.version.substr(0, packageJSON.version.indexOf("-")),
5151
text;
5252

53-
// replace sprint number in short version, e.g. N.<sprint>.N
54-
versionShort = versionShort.replace(/([0-9]+\.)([0-9]+)(\.[0-9]+)/, "$1" + sprint + "$3");
53+
// replace release number in short version, e.g. N.<release>.N
54+
versionShort = versionShort.replace(/([0-9]+\.)([0-9]+)(\.[0-9]+)/, "$1" + release + "$3");
5555

56-
if (!sprint) {
57-
grunt.fail.fatal("Please specify a sprint. e.g. grunt set-sprint --sprint=21");
56+
if (!release) {
57+
grunt.fail.fatal("Please specify a release. e.g. grunt set-release --release=21");
5858
}
5959

6060
// 1. Update package.json
6161
packageJSON.version = safeReplace(
6262
packageJSON.version,
6363
/([0-9]+\.)([0-9]+)([\.\-a-zA-Z0-9]*)?/,
64-
"$1" + sprint + "$3"
64+
"$1" + release + "$3"
6565
);
6666
common.writeJSON(packageJsonPath, packageJSON);
6767

68-
// 2. Open installer/win/brackets-win-install-build.xml and change `product.sprint.number`
68+
// 2. Open installer/win/brackets-win-install-build.xml and change `product.release.number`
6969
text = grunt.file.read(winInstallerBuildXmlPath);
7070
text = safeReplace(
7171
text,
72-
/<property name="product\.sprint\.number" value="([0-9]+)"\/>/,
73-
'<property name="product.sprint.number" value="' + sprint + '"/>'
72+
/<property name="product\.release\.number" value="([0-9]+)"\/>/,
73+
'<property name="product.release.number" value="' + release + '"/>'
7474
);
7575
grunt.file.write(winInstallerBuildXmlPath, text);
7676

7777
// 3. Open installer/mac/buildInstaller.sh and change `releaseName`
7878
text = grunt.file.read(buildInstallerScriptPath);
7979
text = safeReplace(
8080
text,
81-
/( Sprint )([0-9]+)/,
82-
"$1" + sprint
81+
/( Release )([0-9]+)/,
82+
"$1" + release
8383
);
8484
grunt.file.write(buildInstallerScriptPath, text);
8585

@@ -88,12 +88,12 @@ module.exports = function (grunt) {
8888
text = safeReplace(
8989
text,
9090
/(FILEVERSION\s+[0-9]+,)([0-9]+)/,
91-
"$1" + sprint
91+
"$1" + release
9292
);
9393
text = safeReplace(
9494
text,
95-
/(Sprint )([0-9]+)/,
96-
"$1" + sprint
95+
/(Release )([0-9]+)/,
96+
"$1" + release
9797
);
9898
grunt.file.write(versionRcPath, text);
9999

@@ -111,4 +111,4 @@ module.exports = function (grunt) {
111111
);
112112
grunt.file.write(infoPlistPath, text);
113113
});
114-
};
114+
};

0 commit comments

Comments
 (0)