Binary file should not be opened if associated with external application

Author: Nitesh Kumar

src/language/languages.json

@@ -291,7 +291,7 @@
             "jsz", "lib", "mpeg", "mpg", "mp4", "msi", "node", "o", "obj", "odc",
             "odb", "odf", "odg", "odp", "ods", "odt", "otf", "pak", "pdb", "pdf",
             "pdi", "ppt", "pptx", "psd", "rar", "sdf", "so", "sqlite", "suo", "svgz",
-            "swf", "tar", "tif", "tiff", "ttf", "woff", "xls", "xlsx", "zip"
+            "swf", "tar", "tif", "tiff", "ttf", "woff", "xls", "xlsx", "zip", "xd"
         ],
         "isBinary": true
     },

src/project/FileTreeView.js

@@ -555,10 +555,16 @@ define(function (require, exports, module) {
                     });
                 }
             } else {
-                this.props.actions.setSelected(this.myPath(),
-                      FileUtils.shouldOpenInExternalApplication(
-                        FileUtils.getFileExtension(this.myPath()).toLowerCase()
-                      ));
+                var language = LanguageManager.getLanguageForPath(this.myPath()),
+                    doNotOpen = false;
+                if (language && language.isBinary() && "image" !== language.getId() &&
+                        FileUtils.shouldOpenInExternalApplication(
+                            FileUtils.getFileExtension(this.myPath()).toLowerCase()
+                        )
+                    ) {
+                    doNotOpen = true;
+                }
+                this.props.actions.setSelected(this.myPath(), doNotOpen);
             }
             e.stopPropagation();
             e.preventDefault();