Skip to content

Comments

fix: api docs by clarifying file extension requirements in API paths#242

Merged
auniverseaway merged 3 commits intomainfrom
api-docs-ext
Feb 10, 2026
Merged

fix: api docs by clarifying file extension requirements in API paths#242
auniverseaway merged 3 commits intomainfrom
api-docs-ext

Conversation

@kmurugulla
Copy link
Contributor

@kmurugulla kmurugulla commented Feb 9, 2026

Description

In DA admin api docs clarified file extension requirements in API paths

  • Added examples showing file paths must include extensions (e.g., .html, .json)
  • Added examples showing folder paths must omit extensions
  • Clarified version APIs require extensions in path parameters

Related Issue

Motivation and Context

AI coding agents were not actually interpreting the API docs

How Has This Been Tested?

  • generated api docs using npm run build:docs after modification
  • ensured that instructions provided are accurate with respect to files and folders

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue with docs
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Note - Please review the new docs

index.html

@kmurugulla
Copy link
Contributor Author

The integration test failure seems due to stale data in the CI test environment (3 config entries instead of expected 2). This is unrelated to the documentation changes in this PR, which only modify OpenAPI YAML files and don't affect API behavior. A CI environment cleanup or test re-run should resolve this.

@auniverseaway
Copy link
Member

@kmurugulla if you would have told me you were going to do this, I would have said to update the docs in the correct location. :-) Thanks for doing this.

@auniverseaway
Copy link
Member

Oh, one other thing: you'll need to build locally and commit the output. I don't believe our docs update on commit.

@kmurugulla
Copy link
Contributor Author

kmurugulla commented Feb 10, 2026

@kmurugulla if you would have told me you were going to do this, I would have said to update the docs in the correct location. :-) Thanks for doing this.

@auniverseaway - could you please let me know the correct location ?
I have attached the pre built api docs ( index.html) that i generated locally as archive to the PR assuming that they needs to be uploaded to the location that url is pointing to https://opensource.adobe.com/da-admin/ . Also added that index.html to the recent commit . Happy to upload them once you review and give me green

@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@auniverseaway auniverseaway merged commit 7164ffe into main Feb 10, 2026
5 of 6 checks passed
@auniverseaway auniverseaway deleted the api-docs-ext branch February 10, 2026 22:27
adobe-bot pushed a commit that referenced this pull request Feb 10, 2026
## [1.1.4](v1.1.3...v1.1.4) (2026-02-10)

### Bug Fixes

* api docs by clarifying file extension requirements in API paths ([#242](#242)) ([7164ffe](7164ffe)), closes [#129](#129)
adobe-bot pushed a commit that referenced this pull request Feb 18, 2026
## [1.1.4](v1.1.3...v1.1.4) (2026-02-18)

### Bug Fixes

* api docs by clarifying file extension requirements in API paths ([#242](#242)) ([7164ffe](7164ffe)), closes [#129](#129)
@adobe-bot
Copy link
Collaborator

🎉 This PR is included in version 1.1.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[doc]: API - missing extension

3 participants