Skip to content

fix: null doc crashes aem2doc#84

Merged
kptdobe merged 4 commits intomainfrom
empty
Aug 28, 2025
Merged

fix: null doc crashes aem2doc#84
kptdobe merged 4 commits intomainfrom
empty

Conversation

@kptdobe
Copy link
Contributor

@kptdobe kptdobe commented Aug 28, 2025

Should fix observed error:

Problem restoring state from da-admin
TypeError: Cannot read properties of undefined (reading 'children')

Also adding more debugs for next round of errors.

@kptdobe kptdobe requested review from bosschaert and chrischrischris and removed request for chrischrischris August 28, 2025 14:10
@github-actions
Copy link

LCOV of commit 27ee350 during Install, lint, and test #182

Summary coverage rate:
  lines......: 96.4% (1596 of 1655 lines)
  functions..: 96.6% (57 of 59 functions)
  branches...: no data found

Files changed coverage rate:
                  |Lines       |Functions  |Branches    
  Filename        |Rate     Num|Rate    Num|Rate     Num
  ======================================================
  src/collab.js   | 3.8%    426| 0.0%    16|    -      0
  src/shareddoc.js| 3.3%    570| 0.0%    19|    -      0

@kptdobe kptdobe merged commit 6197114 into main Aug 28, 2025
3 checks passed
@kptdobe kptdobe deleted the empty branch August 28, 2025 14:48
adobe-bot pushed a commit that referenced this pull request Dec 8, 2025
# 1.0.0 (2025-12-08)

### Bug Fixes

* add check for shared secret ([#108](#108)) ([a79731f](a79731f))
* add span to known HTML tags ([#101](#101)) ([fbf016d](fbf016d))
* do not empty document if error ([#90](#90)) ([a406add](a406add))
* encode HTML brackets ([#100](#100)) ([6c5b5fd](6c5b5fd))
* encode HTML brackets ([#74](#74)) ([015163e](015163e))
* keep content if no main found in html ([#85](#85)) ([9fd25ac](9fd25ac))
* null doc crashes aem2doc ([#84](#84)) ([6197114](6197114))
* ommit stacktraces in error map for non-dev ([#110](#110)) ([1f896ac](1f896ac))
* remove html comments ([#68](#68)) ([cf05aae](cf05aae))

### Features

* disable stack traces on production ([#109](#109)) ([79c40bd](79c40bd))
* Prevent implicit document creation via If-Match header ([#105](#105)) ([b33ae65](b33ae65))
adobe-bot pushed a commit that referenced this pull request Dec 8, 2025
# 1.0.0 (2025-12-08)

### Bug Fixes

* add check for shared secret ([#108](#108)) ([a79731f](a79731f))
* add span to known HTML tags ([#101](#101)) ([fbf016d](fbf016d))
* do not empty document if error ([#90](#90)) ([a406add](a406add))
* encode HTML brackets ([#100](#100)) ([6c5b5fd](6c5b5fd))
* encode HTML brackets ([#74](#74)) ([015163e](015163e))
* keep content if no main found in html ([#85](#85)) ([9fd25ac](9fd25ac))
* null doc crashes aem2doc ([#84](#84)) ([6197114](6197114))
* ommit stacktraces in error map for non-dev ([#110](#110)) ([1f896ac](1f896ac))
* remove html comments ([#68](#68)) ([cf05aae](cf05aae))
* trigger release ([ca061d4](ca061d4))

### Features

* disable stack traces on production ([#109](#109)) ([79c40bd](79c40bd))
* Prevent implicit document creation via If-Match header ([#105](#105)) ([b33ae65](b33ae65))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants