Feat: Snapshots - Add a link to share the review urls#176
Merged
chrischrischris merged 7 commits intomainfrom Feb 10, 2026
Merged
Feat: Snapshots - Add a link to share the review urls#176chrischrischris merged 7 commits intomainfrom
chrischrischris merged 7 commits intomainfrom
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
chrischrischris
force-pushed
the
ccc-756
branch
from
e7255e4 to
9dd33d6
Compare
Member
|
I don't think the grey will pass accessibility. Maybe a washed out white? |
Contributor
Author
Went with same color as the bar background (s2-gray-50) and verified with accessibility contrast checker. |
Minor CSS tweak to make button have the same padding visually.
auniverseaway
approved these changes
Feb 10, 2026
Member
auniverseaway
left a comment
auniverseaway
left a comment
There was a problem hiding this comment.
Made a small visual tweak so the padding is even on all sides.
When accounting for line height and Adobe Clean nuances, you'll often double the x-axis padding.
padding: 4px 8px;
As some sizes, 8px will be better at 6px (1.5x).
raga-adbe-gh
pushed a commit
to raga-adbe-gh/da-nx
that referenced
this pull request
Feb 10, 2026
* Feat: Snapshots - Add a link to share the review urls Fix: adobe/da-live#756 * Update hover color * Update snapshot.css Minor CSS tweak to make button have the same padding visually. --------- Co-authored-by: Chris Millar <cmillar@adobe.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: adobe/da-live#756