feat: dasc #181 handle arrays, #196 annotate based on schema#198
feat: dasc #181 handle arrays, #196 annotate based on schema#198kozmaadrian merged 29 commits intomainfrom
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits |
| </div> | ||
| <p class="primitive-item-title">${item.schema.title}</p> | ||
| <sl-select name="${item.pointer}" value="${item.data ?? ''}" @change=${this.handleChange}> | ||
| <option value="" disabled>Please Select</option> |
There was a problem hiding this comment.
Since we are not enforcing any values yet, a general non-selectable (disabled) option is added to ensure the UI displays a clear and informative value.
|
|
||
| case 'null': | ||
| return null; | ||
| return schema.default ?? false; |
There was a problem hiding this comment.
As agreed, boolean fields must default to false as a fallback value.
auniverseaway
left a comment
There was a problem hiding this comment.
@kozmaadrian @mhaack at a high level this looks OK to me. Certainly fine to unblock us and move to the schema-first approach. If I start digesting the code more and have issues, I can raise PRs.
@chrischrischris would you mind give this a quick glance? I want to make sure we have SMEs available in US time zone to be able to support this feature. I can give a lot more context when needed.
Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com>
3e14ad9
|
@mhaack @chrischrischris @auniverseaway I’ve applied the requested small change to the PR. Could one of you please help and merge it when you have a moment? |
|
I figured out how to make it run, but found some issues.
But maybe I just didn't set it up correctly, if you have a template I can copy instead of my from-scratch setup here that might help. I used https://da.live/formsref?nx=local#/hannessolo/da-playground/formstest |
|
The boolean might be related to the storage, only "true" is stored. This is fixed by #201 The other two issues are new to me. |
Now fixed
I was missing the title property in the schema
Same, title missing |
hannessolo
left a comment
There was a problem hiding this comment.
I tested it and it looks fine to me to get the core functionality in, as @auniverseaway commented we can always refactor things in a new PR if there's things we don't like.

While working on #181, we realised that we need to modify a core part of the annotation mechanism described in #196.
The refactored annotation mechanism depends on the changes introduced in #181 to properly test both the UI behavior and data persistence.
The updates are split across two separate PRs:
The current PR is intended to provide a clearer view of all changes compared to the main branch.
Demo:
demo-pr-198.mov