Skip to content

Transcreation Support in DA #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auniverseaway merged 1 commit into from
Sep 22, 2025
Merged

Transcreation Support in DA #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 18 additions & 11 deletions nx/blocks/loc/connectors/glaas/api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ export async function createTask({ origin, clientid, token, task, service }) {
const opts = getOpts(clientid, token, JSON.stringify(body), 'application/json', 'POST');

try {
const resp = await fetch(`${origin}/api/l10n/v1.1/tasks/${workflow}/create`, opts);
const resp = await fetch(`${origin}/api/l10n/v1.2/tasks/${workflow}/create`, opts);
if (!resp.ok) throw new Error(resp.status);
return task;
} catch (e) {
Expand All @@ -62,19 +62,21 @@ export async function createTask({ origin, clientid, token, task, service }) {
export async function getTask({ origin, clientid, token, workflow, name }) {
const opts = getOpts(clientid, token);
try {
const resp = await fetch(`${origin}/api/l10n/v1.1/tasks/${workflow}/${name}`, opts);
const resp = await fetch(`${origin}/api/l10n/v1.2/tasks/${workflow}/${name}`, opts);
const json = await resp.json();
return { status: resp.status, json };
} catch {
return { error: 'Error getting task.' };
}
}

// Helper function to ensure GLaaS compatibility with json extensions are converted to html
export const getGlaasFilename = (daBasePath) => (daBasePath.endsWith('.html') ? daBasePath : `${daBasePath}.html`);

export async function addAssets({
origin,
clientid,
token,
langs,
task,
items,
}, actions) {
Expand All @@ -93,16 +95,20 @@ export async function addAssets({
const body = new FormData();

const file = new Blob([item.content], { type: 'text/html' });
const details = {
assetName: item.daBasePath,
const glaasFilename = getGlaasFilename(item.daBasePath);
const fileDetails = {
assetName: glaasFilename,
assetType: 'SOURCE',
targetLocales,
metadata: { 'source-preview-url': item.aemHref },
};

body.append('file1', file, item.daBasePath);
body.append('asset1', new Blob([JSON.stringify(details)], { type: 'application/json; charset=utf-8' }), '_asset_metadata_');
// GLaaS v1.2
body.append('file', file, glaasFilename);

const opts = getOpts(clientid, token, body, null, 'POST');
const url = `${origin}/api/l10n/v1.1/tasks/${workflow}/${name}/assets?targetLanguages=${targetLocales.join(',')}`;
// Add fileDetails parameter for GLaaS v1.2
const url = `${origin}/api/l10n/v1.2/tasks/${workflow}/${name}/assets?targetLanguages=${targetLocales.join(',')}&fileDetails=${encodeURIComponent(JSON.stringify(fileDetails))}`;

try {
const resp = await fetch(url, opts);
Expand All @@ -114,7 +120,7 @@ export async function addAssets({
}));
task.sent += results.filter((result) => (result.status)).length;
task.error += results.filter((result) => (result.error)).length;
updateLangTask(task, langs);
updateLangTask(task, task.langs);
}
if (task.error === 0) task.status = 'uploaded';
}
Expand All @@ -130,7 +136,7 @@ export async function updateStatus(service, token, task, newStatus = 'CREATED')
const opts = getOpts(clientid, token, body, null, 'POST');

const results = await Promise.all(targetLocales.map(async (code) => {
const url = `${origin}/api/l10n/v1.1/tasks/${workflow}/${name}/${code}/updateStatus`;
const url = `${origin}/api/l10n/v1.2/tasks/${workflow}/${name}/${code}/updateStatus`;
try {
const resp = await fetch(url, opts);
if (!resp.ok) throw new Error(resp.status);
Expand All @@ -149,7 +155,7 @@ export async function downloadAsset(service, token, task, path) {
const { origin, clientid } = service;
const { name, workflow, code } = task;
const opts = getOpts(clientid, token, null, null, 'GET');
const url = `${origin}/api/l10n/v1.1/tasks/${workflow}/${name}/assets/${code}${path}`;
const url = `${origin}/api/l10n/v1.2/tasks/${workflow}/${name}/assets/${code}${path}`;
try {
const resp = await fetch(url, opts);
return resp.text();
Expand All @@ -169,6 +175,7 @@ export async function prepareTargetPreview(task, urls, service) {
project: workflowSplit[1],
workflowName,
taskName: name,
useTaskVersion: 'v2',
targetLocales,
urls: urls.map((a) => a.aemHref),
};
Expand Down
Loading