Remove unless from codebases #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
novaugust
force-pushed
the
me/no-more-unless
branch
from
208227b to
3f18d04
Compare
novaugust
force-pushed
the
me/no-more-unless
branch
from
078546c to
7b9e7eb
Compare
remotecom
added a commit
to remoteoss/elixir-styler
that referenced
this pull request
Jun 7, 2025
* ignore no-paren, no-body function heads. closes adobe#185 * minor optimization * Wrap up 1.0.0 docs overhaul * 1.0.0 * Add missing documentation. Closes adobe#188 * update readme link * add more verbiage re styler can add bugs. Closes adobe#186 * reword warning to list examples of breakages * Update styles.md Fixed example for "drop superfluous _..." * Add Stream.run optimizations, fix optimizations shrinking pipes to one line (Closes adobe#180) * fix infinite loop rewriting negated if with empty do body. closes adobe#196 * Remove unless from codebases (adobe#194) * use `not` over `!` when rewriting `unless a (> >= < <= in) b` * actually, lets only do `not` for `in` * v1.1.0 * update version in readme * Don't pipe into `Kernel.!` when rewriting unless with pipes * configs: improve comment handling when moving a small number of nodes. Closes adobe#187 * v1.1.2 * pipes: improve comment behaviour in optimizations (Closes adobe#176) * One-line unpiped assignments (adobe#197) Closes adobe#181 * Pipify: `d(a |> b |> c)` => `a |> b() |> c() |> d()`(adobe#198) Closes adobe#133 * 1.18 hard deprecations (adobe#203) * `List.zip` => `Enum.zip` * `first..last = range` => `first..last//_ = range` * docs and changelog * docs prep for 1.2 * v1.2.0 * correct docs on Enum.into * Fix pipifying pipes-in-pipes (Closes adobe#204) * v1.2.1 * introduce `# styler:sort` comment directive (adobe#205) closes adobe#167 * styler:sort - handle tuples * mix format :X * style:sort - dont dedupe * docs and fix a typo * fiddle with private apis to ease iex playing * remove Zipper.reduce/3 - bugged, but more importantly unused * Maintain comment-node relations when applying `#styler:sort` directive (adobe#207) Co-authored-by: Greg Mefford <[email protected]> Closes adobe#167 * v1.3.0 * correct changelog * fix twople bug in sort directive, add map sorting * v1.3.1 * defstruct with list literal * ci: update elixir and erlang versions * sort directive: sort values of keys. Closes adobe#208 * v1.3.2 * fix comments bug in styler:sort directive * styler:sort arbitrary ast within do end blocks * improve `with` statement replacements * v1.3.3 * alias lifting: shrink when alias already exists. closes adobe#201 * alias lifting: be better about conflicts. Closes adobe#193 * improve alias lift collision case * remove vestigial with rewriting head * pipes: handle pipifying functions whose first arg is itself a pipe. closes adobe#193 * cleanup the messes left in the previous commit 🙈 * correct issue number in change log * test against 1.18 * 1.18 warnings + formatting * no one saw that right? * ex1.17+: replace `:timer.units(x)` with the new `to_timeout(unit: x)` for `hours|minutes|seconds` Closes adobe#218 * 1.18+: change struct updates to map updates. Closes adobe#199 * ensure test works across versions * fix `with` rewrites when keyword with an else stab (adobe#220) Closes adobe#219 fixes for both <1.17 and >=1.17 * pipify nested function calls with pipe as the first argument. closes adobe#216 * change struct update deprecation to ex1.19+ * docs docs docs docs docs! * ship struct update to map update changes after all * v1.4.0 * Add OTP26/27 but only run for 1.17/1.18 * fix `with` redundant body + non-arrow behind redundant clause. Closes adobe#221 * link to quokka * rewrite `to_timeout(unit: x * m)` to use larger units in some cases * defs test describe formatting * dont crash on invalid defs * fix CI for older elixir * v1.4.1 * if: drop empty do bodies. Closes adobe#227 * Fix large comment block mangling bug when ordering sibling AST (adobe#232) Closes adobe#230 * if: treat is_nil as a negator * Revert "if: treat is_nil as a negator" This reverts commit 50ae386. * Revert "if: drop empty do bodies. Closes adobe#227" This reverts commit 6b42462. * v1.4.2 * changelog: fix GH md formatting issues * optimize zipper performance * We still don't want moduledoc false in modules without it * Remove missed conflict --------- Co-authored-by: Matt Enlow <[email protected]> Co-authored-by: Kem Tekinay <[email protected]> Co-authored-by: Matt Enlow <[email protected]> Co-authored-by: Theodor Fiedler <[email protected]> Co-authored-by: Fabian Becker <[email protected]> Co-authored-by: Jesse Herrick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unless is being deprecated
unless is complex to read