Skip to content

fix: remove cleanTemporarily and date-gated API path cleaning #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vdua merged 1 commit into from
Mar 2, 2026
+0 −32
Merged

fix: remove cleanTemporarily and date-gated API path cleaning #607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions src/utils.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,17 +278,6 @@ function cleanCode(str) {
return str;
}

function cleanTemporarily(str) {
return [
[/\/api\/fetchmasterdata.+/i, '/api/fetchmasterdata'],
[/\/api\/masterdatafetch.+/i, '/api/masterdatafetch'],
[/\/api\/mdm.+/i, '/api/mdm'],
[/\/api\/employer.+/i, '/api/employer'],
[/\/api\/perfios.+/i, '/api/perfios'],
[/\/kyccallback.+/i, '/kyccallback'],
].reduce((acc, [regex, replacement]) => acc.replace(regex, replacement), str);
}

export function cleanurl(url) {
// if URL does not parse, return it as is
try {
Expand All @@ -300,9 +289,6 @@ export function cleanurl(url) {
u.hash = '';
u.pathname = cleanPath(u.pathname, ['jwt', 'uuid', 'email']);
u.pathname = cleanCode(u.pathname);
if (new Date() < new Date(2026, 2, 1)) {
u.pathname = cleanTemporarily(u.pathname);
}
return u.toString().replace(/@/g, '');
} catch (e) {
return cleanCode(cleanPath(url, ['jwt', 'uuid', 'email']));
Expand Down
18 changes: 0 additions & 18 deletions test/utils.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,24 +152,6 @@ Pellentesque viverra id magna vel varius. Lorem ipsum dolor sit amet, consectetu
// Combined: UUID with query strings and fragments
assert.equal(cleanurl('https://example.com/user/550e8400-e29b-41d4-a716-446655440000?foo=bar#section'), 'https://example.com/user/%3Cuuid%3E');

// cleanTemporarily function - API paths cleaned until 2026-03-01
assert.equal(cleanurl('https://api.example.com/api/fetchmasterdata?id=12345&token=abc'), 'https://api.example.com/api/fetchmasterdata');
assert.equal(cleanurl('https://api.example.com/api/masterdatafetch/users/all'), 'https://api.example.com/api/masterdatafetch');
assert.equal(cleanurl('https://api.example.com/api/mdm/endpoint/data'), 'https://api.example.com/api/mdm');
assert.equal(cleanurl('https://api.example.com/api/employer/12345/details'), 'https://api.example.com/api/employer');

// perfios and kyccallback endpoints (often have UUIDs)
assert.equal(cleanurl('https://api.example.com/api/perfios.550e8400-e29b-41d4-a716-446655440000'), 'https://api.example.com/api/perfios');
assert.equal(cleanurl('https://api.example.com/api/perfios.123E4567-E89B-12D3-A456-426614174000/data'), 'https://api.example.com/api/perfios');
assert.equal(cleanurl('https://api.example.com/kyccallback.550e8400-e29b-41d4-a716-446655440000'), 'https://api.example.com/kyccallback');
assert.equal(cleanurl('https://api.example.com/kyccallback.550e8400e29b41d4a716446655440000/status'), 'https://api.example.com/kyccallback');
assert.equal(cleanurl('https://api.example.com/kyccallback'), 'https://api.example.com/kyccallback');

assert.equal(cleanurl('https://api.example.com/API/FetchMasterData?foo=bar'), 'https://api.example.com/API/FetchMasterData');
assert.equal(cleanurl('https://api.example.com/api/MasterDataFetch/something'), 'https://api.example.com/api/masterdatafetch');
assert.equal(cleanurl('https://api.example.com/API/Perfios/123e4567-e89b-12d3-a456-426614174000'), 'https://api.example.com/api/perfios');
assert.equal(cleanurl('https://api.example.com/KYCCallback/data'), 'https://api.example.com/kyccallback');

// AEM Asset identifiers - should be preserved
// Test 1: AEM Assets with URN identifier (base path)
assert.equal(cleanurl('https://assets.adobe.com/adobe/assets/urn:aaid:aem:12345678-1234-1234-1234-123456789abc'), 'https://assets.adobe.com/adobe/assets/urn:aaid:aem:12345678-1234-1234-1234-123456789abc');
Expand Down