-
Notifications
You must be signed in to change notification settings - Fork 55
feat: add YouTube chapter markers to community feed #880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
trieloff
wants to merge
2
commits into
main
Choose a base branch
from
youtube-chapter-markers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,6 +6,68 @@ import { | |
| decorateGuideTemplateCodeBlock, | ||
| } from '../../scripts/scripts.js'; | ||
|
|
||
| // Convert timestamp to seconds | ||
| function timeToSeconds(time) { | ||
| const parts = time.split(':').map(Number); | ||
| if (parts.length === 3) { | ||
| return parts[0] * 3600 + parts[1] * 60 + parts[2]; | ||
| } | ||
| return parts[0] * 60 + parts[1]; | ||
| } | ||
|
|
||
| // Parse timestamps from video description | ||
| function parseChapterTimestamps(description, videoUrl) { | ||
| if (!description) return []; | ||
|
|
||
| // Match timestamps like 00:00, 0:00, 01:23, 1:23:45 | ||
| const timestampRegex = /(?:^|\n)(\d{1,2}:?\d{1,2}:\d{2}|\d{1,2}:\d{2})\s+([^\n]+)/g; | ||
| const chapters = []; | ||
| let match = timestampRegex.exec(description); | ||
|
|
||
| while (match !== null) { | ||
| const [, time, title] = match; | ||
| const seconds = timeToSeconds(time); | ||
| chapters.push({ | ||
| timestamp: time, | ||
| title: title.trim(), | ||
| seconds, | ||
| url: `${videoUrl}&t=${seconds}s`, | ||
| }); | ||
| match = timestampRegex.exec(description); | ||
| } | ||
|
Comment on lines
+25
to
+37
|
||
|
|
||
| return chapters; | ||
| } | ||
|
|
||
| // Create chapter markers UI | ||
| function createChapterMarkers(chapters) { | ||
| if (!chapters || chapters.length === 0) return null; | ||
|
|
||
| const chaptersContainer = createTag('div', { class: 'chapter-markers' }); | ||
| const chaptersTitle = createTag('h4', { class: 'chapters-title' }, 'Chapters'); | ||
| chaptersContainer.appendChild(chaptersTitle); | ||
|
|
||
| const chaptersList = createTag('ul', { class: 'chapters-list' }); | ||
| chapters.forEach((chapter) => { | ||
| const listItem = createTag('li', { class: 'chapter-item' }); | ||
| const link = createTag('a', { | ||
| href: chapter.url, | ||
| target: '_blank', | ||
| class: 'chapter-link', | ||
| }); | ||
| const timestamp = createTag('span', { class: 'chapter-timestamp' }, chapter.timestamp); | ||
| const title = createTag('span', { class: 'chapter-title' }, chapter.title); | ||
|
|
||
| link.appendChild(timestamp); | ||
| link.appendChild(title); | ||
| listItem.appendChild(link); | ||
| chaptersList.appendChild(listItem); | ||
| }); | ||
|
|
||
| chaptersContainer.appendChild(chaptersList); | ||
| return chaptersContainer; | ||
| } | ||
|
|
||
| // logic for rendering the community feed | ||
| export async function renderFeed(block) { | ||
| if (!block) { | ||
|
|
@@ -44,6 +106,13 @@ export async function renderFeed(block) { | |
| image.appendChild(img); | ||
| div.appendChild(image); | ||
|
|
||
| // Add chapter markers if timestamps are found in description | ||
| const chapters = parseChapterTimestamps(page.Description, page.URL); | ||
| const chapterMarkers = createChapterMarkers(chapters); | ||
| if (chapterMarkers) { | ||
| div.appendChild(chapterMarkers); | ||
| } | ||
|
|
||
| gridDiv.appendChild(div); | ||
| if (index % 3 === 2 || index === archivePageIndex.length - 1) { | ||
| parentDiv.appendChild(gridDiv); | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.