Skip to content

fix: improve DCR consistency and safety#82

Open
telegrapher wants to merge 11 commits intochore/docs-ci-improvementsfrom
fix/dcr-consistency
Open

fix: improve DCR consistency and safety#82
telegrapher wants to merge 11 commits intochore/docs-ci-improvementsfrom
fix/dcr-consistency

Conversation

@telegrapher
Copy link
Collaborator

Summary

  • Fix JSON injection vulnerability in DCR payload construction — replaced manual string concatenation with json.Marshal for proper escaping of client names and redirect URIs.
  • Use httpClient() instead of http.DefaultClient so proxy, TLS, and timeout settings apply to DCR requests.
  • Simplify Register() return type from RegisterResponse{StatusCode, Body} to (string, error), matching all other commands in the package.
  • Add URL validation via validateURL() to DCR config validation.
  • Fix error wrapping (%v%w) across DCR files for proper error chain propagation.
  • Add missing Apache 2.0 license headers to ims/register.go, ims/client.go, and cmd/dcr.go.
  • Output pretty-printed JSON instead of raw body + status code, consistent with other commands.

telegrapher and others added 9 commits February 28, 2026 18:06
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant