Conversation
…aking) - Accept both colorspace and colorSpace in Color/Theme/createScale; prefer colorSpace - Add colorSpace getter/setter; keep colorspace as deprecated alias with console.warn - Theme.updateColor accepts param.colorSpace ?? param.colorspace - TypeScript: add colorSpace to types, @deprecated colorspace - docs/ui: use colorSpace in config, URL serialization, and internal classes - URL config parsing supports both keys for backward compatibility Refs #190, supersedes approach in PR #191 (deprecation alias avoids breaking change). Co-authored-by: Cursor <cursoragent@cursor.com>
🦋 Changeset detectedLatest commit: f6ac136 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-authored-by: Cursor <cursoragent@cursor.com>
…utParameters.js Co-authored-by: Cursor <cursoragent@cursor.com>
- Fix convertColorValue return type: overloads for object=true (Record<string, number>) vs default (string) - Fix createScale return type: overloads for asFun=true (Scale) vs default (CssColor[]) - Export consumer-facing types: CssColor, Colorspace, CreateScaleOptions, etc. - Add chroma-js.d.ts shim for type-checking without @types/chroma-js - Add tsd and test/index.test-d.ts to lock return types and prevent regressions - Add moon test-types task for CI Co-authored-by: Cursor <cursoragent@cursor.com>
Use continue-on-error for moonrepo/run-report-action so missing or invalid MOON_GH_TOKEN (e.g. on fork PRs) does not mark the job failed. Co-authored-by: Cursor <cursoragent@cursor.com>
c87d5b1 to
fd57eeb
Compare
Run report for f6ac136cTotal time: 15.1s | Comparison time: 28.4s | Estimated savings: 13.3s (46.8% faster)
Touched files |
- Run moon ci with tee to save full output to moon-ci.log - Upload moon-ci.log artifact when job fails for debugging - Use GITHUB_TOKEN for run-report-action instead of MOON_GH_TOKEN Co-authored-by: Cursor <cursoragent@cursor.com>
…puts - CI: use GITHUB_TOKEN, run pnpm install --frozen-lockfile before moon ci, upload moon-ci.log on failure, continue-on-error for run-report - Moon: use @group() instead of @globs() for task inputs/outputs so contrast-colors literal sources are hashed and cache invalidates correctly Co-authored-by: Cursor <cursoragent@cursor.com>
…colors Co-authored-by: Cursor <cursoragent@cursor.com>
- Use colorSpace (not colorspace) in Color._generateColorScale to avoid spamming deprecation warning on every scale regeneration - Use colorSpaceVal in params.js OKLAB/OKLCH smoothing check so URL configs with old colorspace key still enable first-color smoothing - Add console.warn in theme.js updateColor when deprecated colorspace key is used (consistent with Color constructor/setter) - Fix Output error message to reference this._output not colorSpace Co-authored-by: Cursor <cursoragent@cursor.com>
Follow-up bug fixes (pushed to this branch)A few issues in the deprecation-alias implementation were fixed in commit
The |
|
The changes to the index.d.ts and tests are also satisfy the original intent of the #102 pr. |
Replaces
colorspacewithcolorSpacefor consistency (fixes #190) without a breaking change.Approach: deprecation alias
updateColoraccept bothcolorspaceandcolorSpace;colorSpacetakes precedence. NewcolorSpacegetter/setter;colorspacekept as deprecated alias withconsole.warn.colorSpace, warn whencolorspaceis used.colorSpaceadded toColorBaseandcreateScaleoptions;colorspacemarked@deprecated.colorSpacein config, URL serialization, and internal scale classes. URL config parsing supports both keys for backward compatibility.Existing code continues to work; a future major can remove the deprecated form.
Supersedes the approach in PR #191 (which was a breaking rename); this PR implements the deprecation-alias strategy commented on that PR.
Made with Cursor