-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Typescript 5.5.0 upgrade #6370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Typescript 5.5.0 upgrade #6370
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
a9909c1
Typescript 5.5.0 upgrade
snowystinger bce50f0
resolve issue with framer motion
snowystinger dc56e86
Merge branch 'main' into aggregate-ts-upgrade-updates
snowystinger 5e9199d
Review comments
snowystinger 719fa8c
Update ColorPicker.stories.tsx
snowystinger 9ff27d5
Deduped, fixed a new ts error, patched problem dependency
snowystinger 452f18b
patch
snowystinger f0a4082
Merge branch 'main' into aggregate-ts-upgrade-updates
snowystinger 19518da
fix our docs typecheck
snowystinger 7f8312f
Merge branch 'main' into aggregate-ts-upgrade-updates
snowystinger c7fd13a
Bump to 5.5 beta
snowystinger 73e0d08
bump ts version
snowystinger 88ce7f3
Merge branch 'main' into aggregate-ts-upgrade-updates
LFDanLu c22796b
Merge branch 'main' into aggregate-ts-upgrade-updates
snowystinger d124724
Merge branch 'main' into aggregate-ts-upgrade-updates
snowystinger 1786deb
Merge branch 'main' into aggregate-ts-upgrade-updates
snowystinger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
diff --git a/node_modules/ast-types/lib/main.d.ts b/node_modules/ast-types/lib/main.d.ts | ||
index 9b54fef..5c38539 100644 | ||
--- a/node_modules/ast-types/lib/main.d.ts | ||
+++ b/node_modules/ast-types/lib/main.d.ts | ||
@@ -1,7 +1,7 @@ | ||
-import { ASTNode, Type, AnyType, Field } from "./types"; | ||
-import { NodePath } from "./node-path"; | ||
+import { ASTNode, type Type, AnyType, Field } from "./types"; | ||
+import { type NodePath } from "./node-path"; | ||
import { namedTypes } from "./gen/namedTypes"; | ||
-import { builders } from "./gen/builders"; | ||
+import { type builders } from "./gen/builders"; | ||
import { Visitor } from "./gen/visitor"; | ||
declare const astNodesAreEquivalent: { | ||
(a: any, b: any, problemPath?: any): boolean; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6797,13 +6797,6 @@ ast-types-flow@^0.0.7: | |
resolved "https://registry.yarnpkg.com/ast-types-flow/-/ast-types-flow-0.0.7.tgz#f70b735c6bca1a5c9c22d982c3e39e7feba3bdad" | ||
integrity sha1-9wtzXGvKGlycItmCw+Oef+ujva0= | ||
|
||
[email protected]: | ||
version "0.14.2" | ||
resolved "https://registry.yarnpkg.com/ast-types/-/ast-types-0.14.2.tgz#600b882df8583e3cd4f2df5fa20fa83759d4bdfd" | ||
integrity sha512-O0yuUDnZeQDL+ncNGlJ78BiO4jnYI3bvMsD5prT0/nsgijG/LpNBIr63gTjVTNsiGkgQhiyCShTgxt8oXOrklA== | ||
dependencies: | ||
tslib "^2.0.1" | ||
|
||
ast-types@^0.16.1: | ||
version "0.16.1" | ||
resolved "https://registry.yarnpkg.com/ast-types/-/ast-types-0.16.1.tgz#7a9da1617c9081bc121faafe91711b4c8bb81da2" | ||
|
@@ -19769,14 +19762,15 @@ readdirp@~3.6.0: | |
dependencies: | ||
picomatch "^2.2.1" | ||
|
||
recast@^0.20: | ||
version "0.20.5" | ||
resolved "https://registry.yarnpkg.com/recast/-/recast-0.20.5.tgz#8e2c6c96827a1b339c634dd232957d230553ceae" | ||
integrity sha512-E5qICoPoNL4yU0H0NoBDntNB0Q5oMSNh9usFctYniLBluTthi3RsQVBXIJNbApOlvSwW/RGxIuokPcAc59J5fQ== | ||
recast@^0.23: | ||
version "0.23.9" | ||
resolved "https://registry.yarnpkg.com/recast/-/recast-0.23.9.tgz#587c5d3a77c2cfcb0c18ccce6da4361528c2587b" | ||
integrity sha512-Hx/BGIbwj+Des3+xy5uAtAbdCyqK9y9wbBcDFDYanLS9JnMqf7OeF87HQwUimE87OEc72mr6tkKUKMBBL+hF9Q== | ||
dependencies: | ||
ast-types "0.14.2" | ||
ast-types "^0.16.1" | ||
esprima "~4.0.0" | ||
source-map "~0.6.1" | ||
tiny-invariant "^1.3.3" | ||
tslib "^2.0.1" | ||
|
||
recast@^0.23.1, recast@^0.23.3: | ||
|
@@ -22382,10 +22376,10 @@ typescript-strict-plugin@^2.0.0: | |
ora "^5.4.1" | ||
yargs "^16.2.0" | ||
|
||
typescript@^5.3.3: | ||
version "5.3.3" | ||
resolved "https://registry.yarnpkg.com/typescript/-/typescript-5.3.3.tgz#b3ce6ba258e72e6305ba66f5c9b452aaee3ffe37" | ||
integrity sha512-pXWcraxM0uxAS+tN0AG/BF2TyqmHO014Z070UsJ+pFvYuRSq8KH8DmWpnbXe0pEPDHXZV3FcAbJkijJ5oNEnWw== | ||
typescript@^5.5.0: | ||
version "5.5.2" | ||
resolved "https://registry.yarnpkg.com/typescript/-/typescript-5.5.2.tgz#c26f023cb0054e657ce04f72583ea2d85f8d0507" | ||
integrity sha512-NcRtPEOsPFFWjobJEtfihkLCZCXZt/os3zf8nTxjVH3RvTSxjrCamJpbExGvYOF+tFHc3pA65qpdwPbzjohhew== | ||
|
||
[email protected]: | ||
version "0.7.17" | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how big a breaking change is this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And perhaps more importantly, why it's needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a possible suggestion from #6366 (comment)
not sure the least breaking change way to go about this one, but also still have nice syntax
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, in this case, it sounds like we were already "targetting" ES2018, only unknowingly :D Then I suppose it's not going to be a huge deal, still, worth a place in the release notes for sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's worth noting that Parcel doesn't really honour the tsconfig target anyway in its transpilation, it just aims for compatibility with the set of browsers resolved by browserslist.
Since none of the versions on that list is older than 2019, this seems like it should have zero repercussions.