-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[WIP]: Explore editmode #8628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
snowystinger
wants to merge
5
commits into
main
Choose a base branch
from
explore-editmode
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[WIP]: Explore editmode #8628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build successful! 🎉 |
Build successful! 🎉 |
## API Changes
react-aria-components/react-aria-components:Cell Cell {
+ allowsEditing?: boolean
children?: ChildrenOrFunction<CellRenderProps>
className?: ClassNameOrFunction<CellRenderProps>
colSpan?: number
id?: Key
textValue?: string
} /react-aria-components:CellProps CellProps {
+ allowsEditing?: boolean
children?: ChildrenOrFunction<CellRenderProps>
className?: ClassNameOrFunction<CellRenderProps>
colSpan?: number
id?: Key
textValue?: string
} /react-aria-components:CellRenderProps CellRenderProps {
+ endEditing: () => void
id?: Key
+ isEditing: boolean
isFocusVisible: boolean
isFocused: boolean
isHovered: boolean
isPressed: boolean
+ startEditing: () => void
} /react-aria-components:TableState TableState <T> {
collection: TableCollection<T>
disabledKeys: Set<Key>
+ editingKey: Key | null
+ endEditing: () => void
isKeyboardNavigationDisabled: boolean
selectionManager: SelectionManager
setKeyboardNavigationDisabled: (boolean) => void
showSelectionCheckboxes: boolean
sort: (Key, 'ascending' | 'descending') => void
sortDescriptor: SortDescriptor | null
+ startEditing: (Key) => void
} @react-aria/grid/@react-aria/grid:GridCellAria GridCellAria {
gridCellProps: DOMAttributes
+ isEditing: boolean
isPressed: boolean
} @react-aria/table/@react-aria/table:TableCellAria TableCellAria {
gridCellProps: DOMAttributes
+ isEditing: boolean
isPressed: boolean
} @react-spectrum/s2/@react-spectrum/s2:Cell Cell {
align?: 'start' | 'center' | 'end' = 'start'
+ allowsEditing?: boolean
children: ReactNode
className?: ClassNameOrFunction<CellRenderProps>
colSpan?: number
id?: Key
style?: StyleOrFunction<CellRenderProps>
textValue?: string
} /@react-spectrum/s2:CellProps CellProps {
align?: 'start' | 'center' | 'end' = 'start'
+ allowsEditing?: boolean
children: ReactNode
className?: ClassNameOrFunction<CellRenderProps>
colSpan?: number
id?: Key
style?: StyleOrFunction<CellRenderProps>
textValue?: string
} @react-stately/grid/@react-stately/grid:GridState GridState <C extends GridCollection<T>, T> {
collection: GridCollection<T>
disabledKeys: Set<Key>
+ editingKey: Key | null
+ endEditing: () => void
isKeyboardNavigationDisabled: boolean
selectionManager: SelectionManager
+ setKeyboardNavigationDisabled: (boolean) => void
+ startEditing: (Key) => void
} @react-stately/table/@react-stately/table:TableState TableState <T> {
collection: TableCollection<T>
disabledKeys: Set<Key>
+ editingKey: Key | null
+ endEditing: () => void
isKeyboardNavigationDisabled: boolean
selectionManager: SelectionManager
setKeyboardNavigationDisabled: (boolean) => void
showSelectionCheckboxes: boolean
sort: (Key, 'ascending' | 'descending') => void
sortDescriptor: SortDescriptor | null
+ startEditing: (Key) => void
} /@react-stately/table:TreeGridState TreeGridState <T> {
collection: TableCollection<T>
disabledKeys: Set<Key>
+ editingKey: Key | null
+ endEditing: () => void
expandedKeys: 'all' | Set<Key>
isKeyboardNavigationDisabled: boolean
keyMap: Map<Key, GridNode<T>>
selectionManager: SelectionManager
setKeyboardNavigationDisabled: (boolean) => void
showSelectionCheckboxes: boolean
sort: (Key, 'ascending' | 'descending') => void
sortDescriptor: SortDescriptor | null
+ startEditing: (Key) => void
toggleKey: (Key) => void
userColumnCount: number
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
bringing https://github.com/adobe/react-spectrum/tree/edit-mode back to life
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: