fix: Fix crash in RAC Table DnD keyboard navigation #8645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chirokas
changed the title
LFDanLu
approved these changes
Oct 22, 2025
Member
LFDanLu
left a comment
LFDanLu
left a comment
There was a problem hiding this comment.
Apologies for the delay, but looks good to me. Did some extra testing around sections + DnD and tree loaders + DnD but the things I found are unrelated to your changes here so I'll file some issues for the team to handle later. Thanks for the fix!
| @@ -195,7 +195,7 @@ export function renderAfterDropIndicators(collection: ICollection<Node<unknown>> | |||
| let afterIndicators: ReactNode[] = []; | |||
| if (nextItemInSameLevel == null) { | |||
| let current: Node<unknown> | null = node; | |||
| while (current && (!nextItemInFlattenedCollection || (current.parentKey !== nextItemInFlattenedCollection.parentKey && nextItemInFlattenedCollection.level < current.level))) { | |||
| while (current?.type === 'item' && (!nextItemInFlattenedCollection || (current.parentKey !== nextItemInFlattenedCollection.parentKey && nextItemInFlattenedCollection.level < current.level))) { | |||
Member
There was a problem hiding this comment.
We might need to tweak to for the eventual tree with sections case? This is fine for now, I'm not really sure if after drop positions would ever become available for sections
snowystinger
approved these changes
Oct 22, 2025
github-project-automation
bot
moved this from 🩺 To Triage
to 👀 In Review
in RSP Component Milestones
github-project-automation
bot
moved this from 👀 In Review
to ✅ Done
in RSP Component Milestones
bsmiley1
pushed a commit
to bsmiley1/react-spectrum
that referenced
this pull request
Dec 5, 2025
* test * Fix crash on renderAfterDropIndicators in Table * Fix table dnd keyboard navigation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
tablebody,loader) since they can't be drop targets.✅ Pull Request Checklist:
📝 Test Instructions:
In the Dnd Table Example/tableview dnd story, start a keyboard drag session and hold ArrowUp to cycle through the table multiple times.
🧢 Your Project: