Skip to content

chore: use hook data from useDate*Picker to apply calendar props #8649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 22, 2025
Merged

chore: use hook data from useDate*Picker to apply calendar props #8649

merged 3 commits into from
Aug 22, 2025

Conversation

snowystinger
Copy link
Member

Closes
Because of work here:
#8587 (comment)

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

these props should all continue to work as before
firstDayOfWeek
isDateUnavailable
pageBehavior

🧢 Your Project:

@snowystinger snowystinger changed the title No longer pass calendar props explicitly chore: use hook data from useDate*Picker to apply calendar props Jul 29, 2025
@rspbot
Copy link

rspbot commented Jul 29, 2025

Build successful! 🎉

@devongovett
Copy link
Member

oh hmm, while writing the docs I removed these props from DatePicker in RAC because they didn't actually do anything and you could just pass them directly to Calendar. I assumed they were Spectrum-specific props...

@snowystinger
Copy link
Member Author

oh hmm, while writing the docs I removed these props from DatePicker in RAC because they didn't actually do anything and you could just pass them directly to Calendar. I assumed they were Spectrum-specific props...

Yeah, i kind of wondered why they were available on RAC, but I didn't really see a problem with it either... I'm happy for it to go either way.
We'll just have to be careful because we released #8587 (comment) so they do actually go through as of our last release

@devongovett
Copy link
Member

I think that was only merged last week (after the release).

@snowystinger
Copy link
Member Author

O yep, you are right, I looked at the wrong date.

Then I'm happy to close the PR if you've removed them as well in yours. I can link to it and explain on the original PR

@LFDanLu LFDanLu added this pull request to the merge queue Aug 22, 2025
Merged via the queue into main with commit a2caea4 Aug 22, 2025
32 of 33 checks passed
@LFDanLu LFDanLu deleted the no-longer-pass-calendar-props-explicitly branch August 22, 2025 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devongovett devongovett devongovett approved these changes

@LFDanLu LFDanLu LFDanLu approved these changes

Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@snowystinger @rspbot @devongovett @LFDanLu