Skip to content

fix: react types backwards compat for Tabs #8651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LFDanLu merged 2 commits into from
Jul 30, 2025
Merged

fix: react types backwards compat for Tabs #8651

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b854731
fix: react types backwards compat for Tabs
mukul-Ad Jul 29, 2025
2712ac6
Merge branch 'main' into main
MukulAppDev Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/@react-spectrum/tabs/src/Tabs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ function TabLine(props: TabLineProps) {
* A TabList is used within Tabs to group tabs that a user can switch between.
* The keys of the items within the <TabList> must match up with a corresponding item inside the <TabPanels>.
*/
export function TabList<T>(props: SpectrumTabListProps<T>): ReactNode {
export function TabList<T>(props: SpectrumTabListProps<T>): ReactElement {
const tabContext = useContext(TabContext)!;
const {refs, tabState, tabProps, tabPanelProps} = tabContext;
const {isQuiet, density, isEmphasized, orientation} = tabProps;
Expand Down Expand Up @@ -337,7 +337,7 @@ export function TabList<T>(props: SpectrumTabListProps<T>): ReactNode {
* TabPanels is used within Tabs as a container for the content of each tab.
* The keys of the items within the <TabPanels> must match up with a corresponding item inside the <TabList>.
*/
export function TabPanels<T extends object>(props: SpectrumTabPanelsProps<T>): ReactNode {
export function TabPanels<T extends object>(props: SpectrumTabPanelsProps<T>): ReactElement {
const {tabState, tabProps} = useContext(TabContext)!;
const {tabListState} = tabState;

Expand Down