Skip to content

chore: revert OpenTransition prop change to fix undefined TransitionProps in builds #8671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 18, 2025
Merged

chore: revert OpenTransition prop change to fix undefined TransitionProps in builds #8671

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0262f9a
define Transition props
LFDanLu Aug 5, 2025
f321d80
Revert "define Transition props"
LFDanLu Aug 7, 2025
bcf85f7
revert OpenTransition props type to any
LFDanLu Aug 7, 2025
e12aec4
get rid of explicit module check
LFDanLu Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/@react-spectrum/overlays/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
"@react-types/overlays": "^3.9.0",
"@react-types/shared": "^3.31.0",
"@swc/helpers": "^0.5.0",
"@types/react-transition-group": "^4.4.12",
"react-transition-group": "^4.4.5"
},
"devDependencies": {
Expand Down
17 changes: 11 additions & 6 deletions packages/@react-spectrum/overlays/src/OpenTransition.tsx
View file
Open in desktop
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@snowystinger any thoughts on the changes here? Was working on this with @devongovett and the below isn't great since setting children: ReactElement would mean we need to update the types for Overlay and a bunch of other things

Kinda feels like we just fix the build via props: any and call it since its internal only anyways

Copy link
Member

@snowystinger snowystinger Aug 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine for it to be any since it's internal

Might be able to just revert the types for that file and turn off the eslint rule that was added as well for explicit modules if that's the issue

Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,19 @@
* governing permissions and limitations under the License.
*/

import React, {JSX, JSXElementConstructor, ReactElement} from 'react';
import {Transition, TransitionProps} from 'react-transition-group';
import React, {ComponentProps, JSX, JSXElementConstructor, ReactElement} from 'react';
import {Transition} from 'react-transition-group';

const OPEN_STATES = {
entering: false,
entered: true
};

type TransitionProps = ComponentProps<typeof Transition<HTMLElement>>
interface OpenTransitionProps extends Omit<TransitionProps, 'children'> {
children: any
}

/**
* Timeout issues adding css animations to enter may be related to
* https://github.com/reactjs/react-transition-group/issues/189 or
Expand All @@ -32,16 +37,16 @@ const OPEN_STATES = {
*/

export function OpenTransition(
props: TransitionProps
): JSX.Element | ReactElement<any, string | JSXElementConstructor<any>>[] {
props: OpenTransitionProps
): JSX.Element | ReactElement<any, string | JSXElementConstructor<any>>[] {
// Do not apply any transition if in chromatic.
if (process.env.CHROMATIC) {
return React.Children.map(props.children, child => child && React.cloneElement(child, {isOpen: props.in}));
return React.Children.map(props.children, child => child && React.isValidElement(child) && React.cloneElement(child as any, {isOpen: props.in}));
}

return (
<Transition timeout={{enter: 0, exit: 350}} {...props}>
{(state) => React.Children.map(props.children, child => child && React.cloneElement(child, {isOpen: !!OPEN_STATES[state]}))}
{(state) => React.Children.map(props.children, child => child && React.isValidElement(child) && React.cloneElement(child as any, {isOpen: !!OPEN_STATES[state]}))}
</Transition>
);
}
10 changes: 10 additions & 0 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7260,6 +7260,7 @@ __metadata:
"@react-types/overlays": "npm:^3.9.0"
"@react-types/shared": "npm:^3.31.0"
"@swc/helpers": "npm:^0.5.0"
"@types/react-transition-group": "npm:^4.4.12"
react-transition-group: "npm:^4.4.5"
peerDependencies:
"@react-spectrum/provider": ^3.0.0
Expand Down Expand Up @@ -10597,6 +10598,15 @@ __metadata:
languageName: node
linkType: hard

"@types/react-transition-group@npm:^4.4.12":
version: 4.4.12
resolution: "@types/react-transition-group@npm:4.4.12"
peerDependencies:
"@types/react": "*"
checksum: 10c0/0441b8b47c69312c89ec0760ba477ba1a0808a10ceef8dc1c64b1013ed78517332c30f18681b0ec0b53542731f1ed015169fed1d127cc91222638ed955478ec7
languageName: node
linkType: hard

"@types/react@npm:19.1.8":
version: 19.1.8
resolution: "@types/react@npm:19.1.8"
Expand Down