Fix: DOMLayoutDelegate miscalculates item & visible rects #8696
+11
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwidynski
changed the title
nwidynski
changed the title
nwidynski
commented
Aug 10, 2025
Comment on lines
-37
to
-38
| x: itemRect.left - containerRect.left + container.scrollLeft, | ||
| y: itemRect.top - containerRect.top + container.scrollTop, |
There was a problem hiding this comment.
Does anyone know why the item rect was offset by the current scroll point?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Scrollport coincides with the padding box, which should not include border offset. We were calculating on
offsetWidth& bounding boxes instead ofclientWidthand for some reason shifted the item rect by scroll offset??With this change, the DOM layout is now consistent with our virtualized ones 👍
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: