Skip to content

docs: S2 docs fixes from testing (broken links and more) #8982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Oct 8, 2025
Merged

docs: S2 docs fixes from testing (broken links and more) #8982

merged 14 commits into from
Oct 8, 2025

Conversation

reidbarber
Copy link
Member

@reidbarber reidbarber commented Oct 6, 2025 •
edited
Loading

  • Fixed broken links throughout docs
  • Added some additional component illustrations where relevant
  • Improved Popover custom anchor example

Note we renamed Styling.mdx to styling.mdx and Migrating.mdx to migrating.mdx for lowercase links (our standard for non-components).

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot
Copy link

rspbot commented Oct 6, 2025

Build successful! 🎉

@reidbarber reidbarber changed the title docs: S2 docs fixes from testing (broken links and more) WIP: docs: S2 docs fixes from testing (broken links and more) Oct 6, 2025
@reidbarber reidbarber changed the title WIP: docs: S2 docs fixes from testing (broken links and more) docs: S2 docs fixes from testing (broken links and more) Oct 6, 2025
@rspbot
Copy link

rspbot commented Oct 6, 2025

Build successful! 🎉

@rspbot
Copy link

rspbot commented Oct 6, 2025

Build successful! 🎉

@rspbot
Copy link

rspbot commented Oct 7, 2025

Build successful! 🎉

LFDanLu
LFDanLu approved these changes Oct 7, 2025
View reviewed changes
Copy link
Member

@LFDanLu LFDanLu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, wonder if we could make the links pointing to the old docs automatically open in new tab but not a big deal

@LFDanLu LFDanLu added this pull request to the merge queue Oct 8, 2025
Merged via the queue into main with commit d24dbdd Oct 8, 2025
32 checks passed
@LFDanLu LFDanLu deleted the testing-docs-fixes branch October 8, 2025 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LFDanLu LFDanLu LFDanLu approved these changes

@yihuiliao yihuiliao yihuiliao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@reidbarber @rspbot @LFDanLu @yihuiliao