Skip to content

Add allowsEmptyCollection prop in Select component #8984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −3
Open

Add allowsEmptyCollection prop in Select component #8984

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/@react-stately/select/src/useSelectState.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,13 +162,13 @@ export function useSelectState<T extends object, M extends SelectionMode = 'sing
focusStrategy,
open(focusStrategy: FocusStrategy | null = null) {
// Don't open if the collection is empty.
if (listState.collection.size !== 0) {
if (listState.collection.size !== 0 || props.allowsEmptyCollection) {
setFocusStrategy(focusStrategy);
triggerState.open();
}
},
toggle(focusStrategy: FocusStrategy | null = null) {
if (listState.collection.size !== 0) {
if (listState.collection.size !== 0 || props.allowsEmptyCollection) {
setFocusStrategy(focusStrategy);
triggerState.toggle();
}
Expand Down
4 changes: 3 additions & 1 deletion packages/@react-types/select/src/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,9 @@ export interface SelectProps<T, M extends SelectionMode = 'single'> extends Coll
/** Sets the default open state of the menu. */
defaultOpen?: boolean,
/** Method that is called when the open state of the menu changes. */
onOpenChange?: (isOpen: boolean) => void
onOpenChange?: (isOpen: boolean) => void,
/** Whether the select should be allowed to be open when the collection is empty. */
allowsEmptyCollection?: boolean
}

export interface AriaSelectProps<T, M extends SelectionMode = 'single'> extends SelectProps<T, M>, DOMProps, AriaLabelingProps, FocusableDOMProps {
Expand Down