fix: remove unnecessary dependencies#9816
Merged
devongovett merged 3 commits intomainfrom Mar 23, 2026
Merged
Conversation
|
Build successful! 🎉 |
devongovett
reviewed
Mar 20, 2026
| "devDependencies": { | ||
| "@adobe/spectrum-css-temp": "3.0.0-alpha.1", | ||
| "@react-spectrum/test-utils-internal": "3.0.0-alpha.1" | ||
| "@adobe/spectrum-css-temp": "3.0.0-alpha.1" |
Member
There was a problem hiding this comment.
probably don't need this one anymore either
Member
Author
There was a problem hiding this comment.
yeah, I was mulling that one over, I'll go ahead and remove it
hooray for simplifying our constraints!
Member
Author
There was a problem hiding this comment.
probably don't even need the dependency on react for them either....
eh, then i think they'll get made that they aren't providing the peer that the mono package requires, nevermind
devongovett
previously approved these changes
Mar 20, 2026
|
Build successful! 🎉 |
devongovett
reviewed
Mar 23, 2026
| }, | ||
| "peerDependencies": { | ||
| "@react-spectrum/provider": "^3.9.12", | ||
| "@react-spectrum/provider": "^3.10.14", |
Member
There was a problem hiding this comment.
We can do this separately I guess, but test utils should depend on the monopackage instead.
devongovett
approved these changes
Mar 23, 2026
reidbarber
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
Fixes a number of these
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: