Skip to content

fix(s2/Toast): offset toast above on-screen keyboard on mobile #9833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mrlexcoder wants to merge 3 commits into
base: main
Choose a base branch
from
+6 −1
Open

fix(s2/Toast): offset toast above on-screen keyboard on mobile #9833

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9123f2d
fix(s2/Toast): offset toast above on-screen keyboard on mobile
mrlexcoder Mar 24, 2026
19da783
fix(s2/Toast): use CSS variable for keyboard offset per review feedback
mrlexcoder Mar 25, 2026
4cf9c4e
fix(s2/Toast): use pure CSS dvh approach for keyboard offset
mrlexcoder Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/@react-spectrum/s2/src/Toast.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,12 @@ const toastRegion = style({
bottom: {
placement: {
bottom: {
default: 16,
// On mobile, when the on-screen keyboard is open the dynamic viewport
// (dvh) shrinks while the layout viewport (vh) stays the same.
// calc(100vh - 100dvh + 16px) equals the keyboard height + 16px,
// keeping the toast above the keyboard on any browser that supports dvh.
// On desktop (no keyboard) 100vh === 100dvh so this reduces to 16px.
default: '[calc(100vh - 100dvh + 16px)]',
Copy link
Member

@snowystinger snowystinger Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is appearing too high off the bottom for me on iOS 26

maybe we can use

Suggested change
default: '[calc(100vh - 100dvh + 16px)]',
default: '[calc(env(safe-area-inset-bottom) + 16px)]',

though that may not work on previous iOS versions, @yihuiliao could you try this?

isExpanded: 0
}
}
Expand Down
Loading