Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates LLMO offboarding to ensure the page-intent audit is disabled alongside other LLMO-related audits, keeping offboarding behavior aligned with the updated/conditional enablement of page-intent.
Changes:
- Add
page-intentto the LLMO offboarding audit disable list. - Update offboarding tests to assert
disableHandlerForSite('page-intent', site)is called.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/controllers/llmo/llmo-onboarding.js |
Adds page-intent to the audits disabled during LLMO config removal/offboarding. |
test/controllers/llmo/llmo-onboarding.test.js |
Extends offboarding assertions to verify page-intent is disabled. |
- Wrap disableHandlerForSite calls in try/catch block - Log warning if individual audit disable fails - Mirror enableAudits pattern to ensure offboarding continues on partial failure
|
This PR will trigger a patch release when merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
page-intentin the LLMO audit disable list during offboardingdisableHandlerForSite('page-intent', site)Tests
npx c8 --check-coverage=false mocha --spec test/controllers/llmo/llmo-onboarding.test.jsNotes