fix: temporal series month/week wrap-around and add year to query pipeline#1376
Merged
danieljchuser merged 1 commit intomainfrom Feb 25, 2026
Merged
fix: temporal series month/week wrap-around and add year to query pipeline#1376danieljchuser merged 1 commit intomainfrom
danieljchuser merged 1 commit intomainfrom
Conversation
…eline Fix month wrap-around in getTemporalCondition using += 12 instead of = 12, and week wrap-around using += 52/53 instead of = 52/53. Add year column to all SQL raw CTEs, query dimensions, and DTO output so cross-year temporal series data can be correctly sorted downstream. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
LeChef318
approved these changes
Feb 25, 2026
solaris007
pushed a commit
that referenced
this pull request
Feb 25, 2026
## [@adobe/spacecat-shared-athena-client-v1.9.3](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-athena-client-v1.9.2...@adobe/spacecat-shared-athena-client-v1.9.3) (2026-02-25) ### Bug Fixes * temporal series month/week wrap-around and add year to query pipeline ([#1376](#1376)) ([b15cfd7](b15cfd7))
Member
|
🎉 This PR is included in version @adobe/spacecat-shared-athena-client-v1.9.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
solaris007
pushed a commit
that referenced
this pull request
Feb 25, 2026
## [@adobe/spacecat-shared-utils-v1.96.2](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-utils-v1.96.1...@adobe/spacecat-shared-utils-v1.96.2) (2026-02-25) ### Bug Fixes * temporal series month/week wrap-around and add year to query pipeline ([#1376](#1376)) ([b15cfd7](b15cfd7))
Member
|
🎉 This PR is included in version @adobe/spacecat-shared-utils-v1.96.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Feb 25, 2026
danieljchuser
added a commit
that referenced
this pull request
Feb 25, 2026
) ## Summary - Reverts commit f07d153 which changed aggregation granularity levels for `link-name`, `button-name`, and `select-name` from `PER_PAGE_PER_COMPONENT` to `PER_COMPONENT` - These changes introduced breaking behavior in the accessibility suggestion aggregation pipeline - This revert restores the original granularity levels to match v1.96.0 behavior ## Context PR #1376 (temporal fix) was merged and published as utils v1.96.2, but it included the aggregation changes from v1.96.1. This revert ensures the next published version (1.96.3) contains only the temporal fix without the breaking aggregation changes. ## Test plan - [x] All existing tests pass (909 passing, 100% coverage) - [x] Test assertions updated to match reverted granularity levels 🤖 Generated with [Claude Code](https://claude.com/claude-code)
solaris007
pushed a commit
that referenced
this pull request
Feb 25, 2026
## [@adobe/spacecat-shared-utils-v1.96.3](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-utils-v1.96.2...@adobe/spacecat-shared-utils-v1.96.3) (2026-02-25) ### Bug Fixes * revert breaking aggregation granularity changes from v1.96.1 ([#1378](#1378)) ([fbc00f4](fbc00f4)), closes [#1376](#1376)
2 tasks
danieljchuser
added a commit
that referenced
this pull request
Feb 25, 2026
## Summary - Bumps `@adobe/spacecat-shared-utils` dependency in athena-client from `1.82.1` to `1.96.3` - v1.96.3 includes the temporal condition month/week wrap-around fix (from #1376) with the aggregation granularity revert (from #1378) ## Context Part of the PTR temporal series bugfix. The athena-client consumes shared-utils via npm (not workspace link), so this explicit bump is needed before downstream consumers (spacecat-api-service) can pick up the fix. ## Test plan - [x] All 180 athena-client tests pass with 100% coverage - [x] No code changes — dependency version bump only 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
solaris007
pushed a commit
that referenced
this pull request
Feb 25, 2026
## [@adobe/spacecat-shared-athena-client-v1.9.4](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-athena-client-v1.9.3...@adobe/spacecat-shared-athena-client-v1.9.4) (2026-02-25) ### Bug Fixes * bump athena-client utils dep to 1.96.3 ([#1379](#1379)) ([03fe3e9](03fe3e9)), closes [#1376](#1376) [#1378](#1378)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getTemporalCondition: changedcurrentMonth = 12tocurrentMonth += 12, so months correctly resolve to Dec, Nov, Oct... instead of all becoming DecembercurrentWeek += 52/53instead ofcurrentWeek = 52/53yearto data pipeline: SQL raw CTE SELECT, query dimensions (alongsideweek/month), andTrafficDataResponseDto.toJSON()— enables correct cross-year sorting downstreamBug introduced in commit aad2d1c (Nov 20, 2025).
Packages affected
spacecat-shared-utilsgetTemporalConditionwrap-around logicspacecat-shared-athena-clientyearto SQL templates, dimension pushes, and DTOTest plan
month=1, numSeries=4→ months [1, 12, 11, 10] with years [2026, 2025, 2025, 2025]week=1, numSeries=5→ weeks [1, 52, 51, 50, 49] across year boundaryyearfield in temporal series data after deploy🤖 Generated with Claude Code