You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
castastrophe
added
ready-for-review
run_vrt
For use on PRs looking to kick off VRT
size-5 L
~30-42hrs; lots of effort or complexity, most of a sprint needed to complete.
size-3 M
~18-30hrs; moderate effort or complexity, several work days needed.
and removed
skip_vrt
Add to a PR to skip running VRT (but still pass the action)
size-5 L
~30-42hrs; lots of effort or complexity, most of a sprint needed to complete.
labels
Jun 27, 2024
The reason will be displayed to describe this comment to others. Learn more.
Nice addition. I was able to test locally by running yarn ci and confirm the validation steps. 🎉
Of note: I tried to unzip the .gz in MacOS via Finder and also with gunzip via command line but it didn't understand the format. It seems this is because the headers use zlib format (file info is "zlib compressed data"). TIL. I think there's an option for gzip style headers or maybe the file could be named .zlib; I'm not sure if that's needed though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buildIssues associated with the build process; often a refactorlow priorityNot a critical update or fix; can be deprioritized if necessaryready-for-reviewsize-3 M~18-30hrs; moderate effort or complexity, several work days needed.skip_vrtAdd to a PR to skip running VRT (but still pass the action)
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR would add a minified and gzipped output for all existing CSS exports. These assets are only created on production builds.
Jira CSS-880
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
To-do list