Skip to content

docs: add more figma assets #3563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 21, 2025
Merged

docs: add more figma assets #3563

merged 10 commits into from
Aug 21, 2025
+40 −0

Conversation

marissahuysentruyt
Copy link
Collaborator

@marissahuysentruyt marissahuysentruyt commented Feb 17, 2025 •
edited
Loading

Description

This PR just adds some more Figma links to a few components that were missing them!

Jira

CSS-978

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

  • Pull down the repo to run locally or visit the deploy preview.
  • Verify that each component's Design tab (found on story pages) correctly links to the Figma file for that component.
    • action menu
    • asset card
    • card
    • calendar
    • clear button
    • color loupe
    • date picker
    • infield button
    • opacity checkerboard
    • steplist

NOTE: The designs are for S2, so most of our components will not match the designs. That's ok 👍

Screenshot 2025-08-21 at 12 31 17 PM

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • The pages render correctly, are accessible, and are responsive.
  1. If components have been modified, VRTs have been run on this branch:
  • VRTs have been run and looked at.
  • Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

Screenshots

To-do list

  • I have read the contribution guidelines.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 17, 2025 •
edited
Loading

File metrics

Summary

Total size: 2.25 MB*

🎉 No changes detected in any packages

* Size is the sum of all main files for packages in the library.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 17, 2025 •
edited
Loading

🚀 Deployed on https://pr-3563--spectrum-css.netlify.app

@marissahuysentruyt marissahuysentruyt added the wip This is a work in progress, don't judge. label Feb 17, 2025
@marissahuysentruyt marissahuysentruyt self-assigned this Feb 17, 2025
@marissahuysentruyt marissahuysentruyt added the do not merge A flag for a branch indicating it should not be merged. label Mar 11, 2025
@castastrophe castastrophe force-pushed the main branch 11 times, most recently from c68f4e3 to d2272ea Compare March 12, 2025 21:56
@castastrophe castastrophe force-pushed the marissahuysentruyt/css-978-figma-assets-follow-up branch from 6f5f757 to 721f685 Compare August 6, 2025 23:40
@castastrophe castastrophe force-pushed the marissahuysentruyt/css-978-figma-assets-follow-up branch from 721f685 to 974bea7 Compare August 21, 2025 15:50
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 21, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8b6afc4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 21, 2025 •
edited
Loading

📚 Branch preview

PR #3563 has been deployed to Azure Blob Storage: https://spectrumcss.z13.web.core.windows.net/pr-3563/index.html.

@marissahuysentruyt marissahuysentruyt removed wip This is a work in progress, don't judge. do not merge A flag for a branch indicating it should not be merged. labels Aug 21, 2025
@marissahuysentruyt marissahuysentruyt marked this pull request as ready for review August 21, 2025 16:35
@marissahuysentruyt marissahuysentruyt added documentation Because documentation is important and shouldn't be broken size-1 XS ~1-6hrs; nearly trivial, a few hours, could do more than one in a single day. skip_vrt Add to a PR to skip running VRT (but still pass the action) labels Aug 21, 2025
@castastrophe castastrophe merged commit 3e67ed2 into main Aug 21, 2025
28 of 36 checks passed
@castastrophe castastrophe deleted the marissahuysentruyt/css-978-figma-assets-follow-up branch August 21, 2025 16:57
castastrophe pushed a commit that referenced this pull request Aug 25, 2025
@marissahuysentruyt @castastrophe
docs: add more figma assets (#3563)
4b84310 
* docs(actionmenu): add figma links
* docs(assetcard): add figma links
* docs(card): add figma links
* docs(infieldbutton): add figma links
* docs(steplist): add figma links
* docs(colorloupe): add figma links
* docs(opacitycheckerboard): add figma links
* docs(calendar): add figma link
* docs(datepicker): add figma link
* docs(clearbutton): add figma link
castastrophe pushed a commit that referenced this pull request Aug 25, 2025
@marissahuysentruyt @castastrophe
docs: add more figma assets (#3563)
c2e1e95 
* docs(actionmenu): add figma links
* docs(assetcard): add figma links
* docs(card): add figma links
* docs(infieldbutton): add figma links
* docs(steplist): add figma links
* docs(colorloupe): add figma links
* docs(opacitycheckerboard): add figma links
* docs(calendar): add figma link
* docs(datepicker): add figma link
* docs(clearbutton): add figma link
castastrophe pushed a commit that referenced this pull request Aug 25, 2025
@marissahuysentruyt @castastrophe
docs: add more figma assets (#3563)
fb183af 
* docs(actionmenu): add figma links
* docs(assetcard): add figma links
* docs(card): add figma links
* docs(infieldbutton): add figma links
* docs(steplist): add figma links
* docs(colorloupe): add figma links
* docs(opacitycheckerboard): add figma links
* docs(calendar): add figma link
* docs(datepicker): add figma link
* docs(clearbutton): add figma link
castastrophe pushed a commit that referenced this pull request Aug 25, 2025
@marissahuysentruyt @castastrophe
docs: add more figma assets (#3563)
1552f76 
* docs(actionmenu): add figma links
* docs(assetcard): add figma links
* docs(card): add figma links
* docs(infieldbutton): add figma links
* docs(steplist): add figma links
* docs(colorloupe): add figma links
* docs(opacitycheckerboard): add figma links
* docs(calendar): add figma link
* docs(datepicker): add figma link
* docs(clearbutton): add figma link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@castastrophe castastrophe castastrophe approved these changes

Assignees

@marissahuysentruyt marissahuysentruyt

Labels
documentation Because documentation is important and shouldn't be broken size-1 XS ~1-6hrs; nearly trivial, a few hours, could do more than one in a single day. skip_vrt Add to a PR to skip running VRT (but still pass the action)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marissahuysentruyt @castastrophe