Skip to content

ci: chromatic runs for S2 [CSS-1233] #4070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
castastrophe merged 1 commit into from
Jul 28, 2025
Merged

ci: chromatic runs for S2 [CSS-1233] #4070

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/development.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,8 @@ jobs:
uses: ./.github/workflows/vrt.yml
with:
skip: ${{ contains(github.event.pull_request.labels.*.name, 'skip_vrt') }}
ref: ${{ github.event.pull_request.head.ref || github.ref_name }}
sha: ${{ github.event.pull_request.head.sha || github.ref }}
secrets: inherit

# -------------------------------------------------------------
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/production.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ jobs:
uses: ./.github/workflows/vrt.yml
with:
skip: ${{ github.base_ref != 'main' }}
ref: ${{ github.ref_name }}
sha: ${{ github.ref }}
secrets: inherit

# -------------------------------------------------------------
Expand Down
16 changes: 15 additions & 1 deletion .github/workflows/vrt.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,16 @@ on:
required: false
type: boolean
default: false
ref:
description: "Branch to test"
required: false
type: string
default: ${{ github.ref }}
sha:
description: "SHA to test"
required: false
type: string
default: ${{ github.ref }}
outputs:
storybook-url:
description: "URL of the published Storybook"
Expand All @@ -37,6 +47,11 @@ jobs:
uses: actions/checkout@v4
with:
fetch-depth: 0
ref: ${{ inputs.ref || github.ref }}
env:
CHROMATIC_BRANCH: ${{ inputs.ref || github.ref_name }}
CHROMATIC_SHA: ${{ inputs.sha || github.ref }}
CHROMATIC_SLUG: ${{ github.repository }}

- name: Use Node LTS version
uses: actions/setup-node@v4
Expand Down Expand Up @@ -79,7 +94,6 @@ jobs:
onlyChanged: true
traceChanged: true
untraced: ".github/* plugins/stylelint-*/* tools/* .changeset/*"
diagnostics: true
Copy link
Contributor Author

@castastrophe castastrophe Jul 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This property is deprecated and no longer supported so I removed it.

autoAcceptChanges: "main"
# Lets VRT pass without running so as not to waste snapshots
skip: ${{ inputs.skip }}
Loading