chore(popover): wrapper placement in story #4173
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* feat(actionbutton): s2 migration Migrates the action button component to spectrum 2, using updated and new design token specs. Includes down state transform, removal of medium class, changes to mod custom properties, and storybook updates. * docs(actionbutton): remove problematic click and focus events - The click event was treating all action buttons as toggles, not allowing testing of the active/down state on click on the default button. It also does not work well when multiple buttons are present. - The focus events were inaccurately showing the focus indicator on click; the styles for this work differently because they are for focus-visible. The focused control/arg is for the storybook only class used for testing, which applies in a different manner. * docs(actionbutton): update docs, selected state toggle Some small documentation improvements, especially around the selected state. Adds additional notes about the selected state being optional and for toggles (per SWC docs and guidelines). * fix(actionbutton): selected + disabled + quiet background color This combination of states should continue to have the background color rather than the quiet transparent background. Per design feedback, the quiet + disabled + selected should display the same as the default disabled + selected. * chore(actionbutton): generate new metadata * chore(actionbutton): add stylelint exception for downstate variables * feat(actionbutton): add font-style property and token * fix(actionbutton): static variants do not support emphasized Update tests to remove static black + emphasized and static white + emphasized, as these are not on the design spec and not supported. Updates some Docs page descriptions to make this clear. * feat(actionbutton): add cjk line-height support Use design spec defined CJK line-height in action button. Replaces line-height declaration coming from the extended BaseButton, along with a mod name appropriate for the component. * fix(actionbutton): high contrast adjustments - Fix for high contrast border styles not being solid. - Quiet variants no longer show a border and blend into background with Canvas and CanvasText color pair. - Focus indicator color changed from ButtonText to CanvasText, because this indicator appears outside of the element (it does not appear on top of a ButtonFace background). * docs(actionbutton): disable static color control if emphasized * docs(actionbutton): add docs link to popover * fix(actionbutton): static + quiet + disabled + selected background Fixes the issue where the static black and white, quiet, selected, and disabled state in the testing grid was showing the static quiet background color instead of the static disabled background color. * fix(actionbutton): set default system colors for high contrast The noted readability backplate issue was present on more than just the selected state; it was just difficult to see without contrasting colors. So this has been moved to the default, along with setting default system color values. * refactor(actionbutton): simplify high contrast styles Refactors high contrast styles and custom properties to remove unnecessary variables, and adds some documentation. * fix(actionbutton): use full line-height to prevent cut off diacritics Keep the previous S1 behavior of setting the line-height to the full component height. This prevents Thai diacritics from being cut off (see existing Storybook test). Note: this line-height is taller than both line-height-100 and cjk-line-height-100 listed on the design spec. Using those had resulted in the diacritics cutting off again. * chore(actionbutton): update changeset description and rebuild metadata * feat(actionbutton): refactor using "has" to reduce complexity Adjust some selectors to use :has in order to remove some overly complex calc functions, and to use the inline spacing tokens more like they are defined on the token specs. Now that :has is supported and used in our library, this simplifies this usage and removes some requirements for the source order of action button's child elements. * docs(actionbutton): remove outdated docs and add static docs Usage notes about using a mod for static colors no longer applies; the --mod-actionbutton-content-color-default-selected mod and similar selected state mods work correctly to change the content color for static. Adds some basic intro docs for static colors, pulled from the guidelines. * docs(actionbutton): add docs story for text overflow behavior * docs(actionbutton): clarify text overflow docs description * docs(actionbutton): remove size medium class from appearing in markup The .spectrum-ActionButton--sizeM class is no longer used but was still appearing in the examples markup. * chore(actionbutton): update copyright year * fix(actionbutton): disable css transitions in high contrast In Windows High Contrast, the border color briefly was flashing orange (ButtonBorder) after hover, before it switched back to the correct color as defined by the styles. This fixes that issue. This removes CSS transitions in high contrast to avoid some of these rendering issues and previously noticed sluggishness in the system color transitions. * chore(actionbutton): rebuild metadata * chore: update changeset * chore(actionbutton): storybook template update --------- Co-authored-by: Melissa Thompson <[email protected]> Co-authored-by: Josh Winn <[email protected]> Co-authored-by: [ Cassondra ] <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* fix: downgrade storybook and set to fixed minor version 8.4 Temporarily downgrade storybook to the previously working 8.4.7, to fix issues occuring in 8.5 and 8.6 that cause all docs descriptions to be missing. * fix: remove deprecated storybook StoryStoreV7 option Remove old option flagged during Storybook upgrade: "StoryStoreV7 feature must be removed from your Storybook configuration. This feature was removed in Storybook 8.0.0."
* feat(helptext): migration WIP * feat(helptext): adding mod for alignment * feat(helptext): adding changeset * feat(helptext): updating changeset * chore(helptext): restore some metadata files * feat(helptext): migration WIP * feat(helptext): adding mod for alignment * chore(helptext): restore some metadata files * feat(helptext): restoring new s2 changes and remaining metadata files * chore(helptext): restoring metadata files again * chore(helptext): adding metadata files * chore(helptext): please metadata dont come back 😅 * chore(helptext): removing button metadata * feat(helptext): restructure css file * chore(helptext): remove some metadata files * feat(helptext): final tweaks * chore(helptext): restoring metadata files
* feat(coachmark): s2 migration - feat(coachmark): line height token - feat: add fixed height coachmark image variation - chore(coachmark): adds description to imageIsFixedHeight control - feat(coachmark): image control in story - fix(coachmark): image source control label - fix(coachmark): fixed height label - fix(coachmark): conditionally show image-dependent controls - fix(coachmark): css syntax error - chore(coachmark): adjust default args - chore(coachmark): update template and tests to handle updated story defaults; update example heights; update default image - chore(coachmark): update arg names - chore(coachmark): refactor stories to display variations and update explainers - chore(coachmark): rough keyboard shortcut implementation - feat: keyboard shortcut revisions, toggle + title control - feat(coachmark): badge tags arg - feat(coachmark): test updates - feat(coachmark): image + fixed height test - fix(coachmark): missing title - chore: resolve conflict - chore(coachmark): move shortcut control - chore: resolve conflict - fix(coachmark): address feedback - remove redundant height args - add class to story docs - update template name(s) - chore(coachmark): remove with/out shortcut from story titles; deduplicate args - chore(coachmark): add fixed height to template heading - chore(coachmark): additional custom properties in changelog - chore(coachmark): add keyboard shortcut notes to changelog - chore(coachmark): clean up + add stories - chore(coachmark): remove keyboard shortcut functionality * fix(coachmark): sets required padding for action menu popover child * fix(coachmark): enforces consistent spacing from image to header and header to text with action menu present Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix(coachmark): use classmap instead of ternary; remove stories from sidebar * fix(coachmark): update changeset heading depth * fix(coachmark): update solution for action menu spacing * chore(coachmark): long title test + update metadata * fix(coachmark): remove repetetive arguments; clarify naming; revert badge template * fix(coachmark): remove unused custom property * fix(coachmark): remove repetitive wrapper styles * fix(coachmark): update font weight token; split out root selector; restore margin * fix(coachmark): flex alignment + tokens changeset --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* fix(tooltip): restore negative and informative semantic variants * fix(tooltip): remove positive semantic variant test * fix(tooltip): deduplicate high contrast color vars
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* chore: move forced colors to bottom for cascade * feat: token value adjustments and design spec alignment - rearranges where some of the textfield mods are (passthroughs) - adds styles for focus+hover in testing - clarifies where the custom properties are in the files - adds some missing tokens for block-start/block-end - removes whitespace in some of the style and/or mod declarations - reimplements custom --spectrum-corner-rounding-full token in global.vars after rebase - removes selectors that are not needed for the border color in key- boardFocus+hover, and colors in mouseFocus+hover states * chore: previous versions for migration guide - removes a stray isQuiet arg from stories * chore: update component name to align with design spec - also updates component name case * docs(search): show new options - remove quiet variant - adds help text story - adds inputValue to control table and corresponding behavior - fixes Search icon - clarify clear button language - add chromatic test coverage - adds aria-label based on guidance page in template - adds headings to SearchOptions template containers - hotfix for textfield's displayLabel arg - adds documentation from guidance page - clarifies some descriptions for args - adds default undefined string to inputValue * fix: token fix and removal of unused, keyboardfocus hover * docs(clearbutton): option to remove from focus for searchfield - remove unnecessary variant control * chore: update stylelint ignore comments - add stylelint disable comments & descriptions * chore(search,tokens): add changeset * chore(searchfield): update metadata * fix(search): fix focus+hover border in WHCM Co-authored-by: Melissa Thompson <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* chore: merge latest from main * docs(button): restore autodocs page after mdx removal * docs(icon): adjust story visibility and order In the switch back to autodocs from a custom MDX, some newly added stories for S2 needed to be hidden for the Docs page, and some story titles needing renaming to keep related stories in order. --------- Co-authored-by: Josh Winn <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* feat(tokens): update to latest release * feat(card): update styles to use refreshed token
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* fix(rating): active state star icon * chore(rating): adopt spacing tokens * chore(rating): remove underline when hovering over active rating stars * chore(rating): update color custom properties * chore(rating): size control * chore(rating): size stories * chore(rating): draft changeset * chore(rating): rating component hover logic * chore(rating): update changelog * chore(rating): add tooltip example, control and tests * chore(rating): refactor isFocused to isKeyboardFocused * fix(rating): default to medium size; remove unnecessary tests and template * fix(rating): update changeset heading depth * fix(rating): remove unused key-focus color styles * chore(rating): separate styles from custom properties; implement spacing tokens * chore(rating): application of rating height tokens * chore(rating): fix focus state + sizing * chore(rating): apply focus indicator gap * chore(rating): apply S2 down state * chore(rating): update changelog * fix(rating): corrects padding issues, flex alignment and removes unused property * chore(rating): add configurable filled star mask with mod to control fill percentage; update docs * fix(rating): remove unnecessary focus states * fix(rating): docs, changelog, testing and style updates * chore(rating): add emphasized + hovered story and test * chore(rating): remove duplicate mod * chore(rating): add removed mod * fix(rating): typo in class name Co-authored-by: rise-erpelding <[email protected]> * chore(rating): remove incorrect mods and custom properties from changelog * fix(rating): remove emphasized state from hover test * fix(rating): adjust block and inline padding for focus states * fix(rating): remove manual hover classes, update class names in template * fix(rating): change EmphasizedHovered story name to Hovered * Revert "fix(rating): adjust block and inline padding for focus states" This reverts commit 2175ea7. * fix(rating): replace padding with outline and outline-offset --------- Co-authored-by: rise-erpelding <[email protected]>
…or changes (#3531) * feat(checkbox): adding new s2 tokens * chore(checkbox): adding necessary files * chore(checkbox): adding necessary files and dist files * chore(checkbox): making tokens more specific * chore(checkbox): adding checkbox dist files * chore(checkbox): remove unnecessary dist files * feat(checkbox): adding checkbox s2 tokens * chore(checkbox): adding metadata file * feat(checkbox): restoring new s2 tokens * chore(checkbox): adding metadata file * feat(checkbox): adding focused and hovered states in test env * feat(checkbox): configure WHCM mode and modify css * chore(checkbox): adding metadata file * feat(checkbox): updating changeset, removing some conflicting classes * chore(checkbox): restoring s2 files * feat(checkbox): fixing emphasized focused state * chore(checkbox): adding metadata * feat(checkbox): updating whcm hover states * feat(checkbox): updating whcm * feat(checkbox): bring back size M * feat(checkbox): updating WHCM and metadata * feat(checkbox): updating checkbox states * feat(checkbox): adding new s2 tokens * chore(checkbox): adding necessary files and dist files * chore(checkbox): making tokens more specific * chore(checkbox): adding checkbox dist files * chore(checkbox): remove unnecessary dist files * feat(checkbox): adding checkbox s2 tokens * feat(checkbox): restoring new s2 tokens * feat(checkbox): adding focused and hovered states in test env * feat(checkbox): configure WHCM mode and modify css * feat(checkbox): updating changeset, removing some conflicting classes * feat(checkbox): fixing emphasized focused state * chore(checkbox): adding metadata * feat(checkbox): updating whcm hover states * feat(checkbox): updating whcm * feat(checkbox): bring back size M * feat(checkbox): updating WHCM and metadata * feat(checkbox): updating checkbox states * chore(checkbox): restoring metadata files * feat(checkbox): fix emphasized unchecked focus state * feat(checkbox): update emphasized error state * chore(checkbox): restore metadata files * feat(checkbox): removing is-focus-visible and is-disabled class usage * chore(checkbox): removing metadata files * feat(checkbox): cleaned house - reorg classes, removed bad selects, cut out some tests * chore(checkbox): restoring search metadata * feat(checkbox): adding active to test grid * feat(checkbox): adding checkbox downstate fix, removing is-active class, and finding indeterminate bug * feat(checkbox): add back test cases * feat(checkbox): adding hovered invalid * feat(checkbox): disable all hover states in disabled state
* chore: adds support to parse "transparent" token references (#3452) * feat(tokens): add transparent token handling * adds transparent mapping into rgb-mapping plugin - custom properties that reference transparent tokens will now be mapped to their corresponding transparent rgb/opacity tokens - extends the work that the rgb-mapping plugin already does * test: add plugin test cases * chore(plugins/postcss-rgb-mapping): update README.md * chore: add changeset * chore: release (#3673) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix(tokens): support style-dictionary build in windows env (#2500) --------- Co-authored-by: Marissa Huysentruyt <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* feat(infield-button): new s2 migration * chore(infield-button): restoring s2 files * feat(infieldbutton): adding downstate function * chore(infieldbutton): removing metadata files * feat(infieldbutton): add supported icons story, add inline side edge tokens, update css * chore(infieldbutton): restoring metadata files * feat(infieldbutton): adding metadata file * feat(infieldbutton): fixing template and story * chore(ifbutton): restoring metadata * feat(ifbutton): updating custom tokens * feat(ifbutton): fixing typos and stuff * feat(ifbutton): adding metadata file * feat(ifbutton): adding field edge to icon tokens * feat(ifbutton): swap custom token sizes and fix story typo * feat(ifbutton): adding new metadata * feat(ifbutton): adding minimum perspective on smallest button size * feat(ifbutton): moving active interaction to style selector * chore(ifbutton): restoring metadata * feat(ifbutton): adjusting mod * chore(ifbutton): restoring actual mod * feat(ifbutton): adding click function to button element * feat(ifbutton): add minus click function for stepper
* chore: update textfield template arg - sets displayLabel as undefined in textfield default args. Before, with displayLabel set to true by default, components such as combobox, search, stepper, had duplicate field label components and offset a bunch of the icons & buttons within those components. With the displayLabel undefined in the default args, any nested textfields in other components will not render the field label that is embedded within the textfield. * chore(search): removes displayLabel arg from nested textfield
* feat(toast): S2 migration * fix(toast): vertical and horizontal spacing * chore(toast): remove unused properties * chore(toast): additional spacing refinements and explanatory comments * marissa wip * styles wip * chore(toast): add .spectrum-Toast--noButton for SWC use * fix(toast): update toast test case message w/out button * fix(toast): update toast has button story * fix(toast): scope close button styles to toast * fix(toast): clean up a few typos --------- Co-authored-by: Marissa Huysentruyt <[email protected]>
…3656) * feat(touch-action): adding touch action to draggable components * chore(touch-action): restoring some metadata files * chore(touch-action): token files * chore(touch-action): adding token files) * chore(touch-action): restoring token css files * chore(touch-action): removing token dist css files * feat(touch-action): adding touch action to slider handle * chore(touch-action): fix typos in changeset * feat(touch-action): adding user select none to color area
* feat(in-line-alert): S2 migration * chore(in-line-alert): allow only subtle or bold * fix(in-line-alert): correct changelog to showcase custom properties rather than selectors * chore(in-line-alert): additional granular mods for background colors * fix(in-line-alert): resolve issues with button colors in bold + subtle variants * chore(in-line-alert): add subtle and bold variants to testing grid * chore(in-line-alert): add subtle + bold closable tests * chore(in-line-alert): add link variant, control and test grid variants * chore(in-line-alert): add style variants to docs view * chore(in-line-alert): refactor and significantly reduce styles * chore(in-line-alert): update docs + customize treatment titles * chore(in-line-alert): update WHC styles; drop button mods; add w/out header story control * fix(in-line-alert): revise WHC colors and restore borders for subtle/bold treatments * fix(in-line-alert): reorder custom properties; drop unnecessary selectors * fix(in-line-alert): set static variations on links and buttons ensure visibility * fix(in-line-alert): icon alignment * fix(in-line-alert): add high contrast border width property * fix(in-line-alert): use req'd font stacks Co-authored-by: [ Cassondra ] <[email protected]> * fix(in-line-alert): border treatment links + buttons * fix(in-line-alert): show icon with text when no header is displayed * chore(in-line-alert): update changelog with usage notes for subtle/bold + markup examples * Update components/inlinealert/index.css Co-authored-by: Josh Winn <[email protected]> * fix(in-line-alert): combine border width declarations --------- Co-authored-by: [ Cassondra ] <[email protected]> Co-authored-by: Josh Winn <[email protected]>
Because the spelling of the "dismissible" arg changed in the dialog component, the spelling needed to be updated in popover as well.
Adds the migrated status to components that have been migrated fully to S2. A migrated badge to the storybook toolbar should now appear for those components.
* feat(search): adding collapsed search feature * feat(search): adding changeset * feat(search): adding keyboard focused state for collapsed search * feat(search): updating changeset copy * feat(search): adding quiet variant to button * feat(search): adding min inline size for elongated animation * feat(search): adding animation speed and proper disabled state * feat(search): remove tabbing when button is disabled * feat(search): adding component specific collapsed animation token
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…4146) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…#4156) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…4158) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ectrum-two) (#4168) * chore(deps): update dependency @adobe/spectrum-tokens to ^13.14.0 * chore(tokens): reflect latest release for diff tool --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: castastrophe <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
🦋 Changeset detectedLatest commit: 581de70 The changes in this PR will be included in the next version bump. This PR includes no changesetsWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
Regression testing
Validate:
Screenshots
To-do list