Skip to content

chore: update field components css dependencies#5085

Merged
rubencarvalho merged 11 commits intomainfrom
ruben/bump-field-components-css
Mar 4, 2025
Merged

chore: update field components css dependencies#5085
rubencarvalho merged 11 commits intomainfrom
ruben/bump-field-components-css

Conversation

@rubencarvalho
Copy link
Contributor

@rubencarvalho rubencarvalho commented Feb 11, 2025

Description

Bumping "field components" to the latest CSS version, to get up to date with the latest Spectrum 2 designs.

Related issue(s)

  • SWC-662

Motivation and context

After the recent release of Spectrum 2 (foundations), we want to keep updating our components to the latest design specs.

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • If my change required a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

@rubencarvalho rubencarvalho requested a review from a team as a code owner February 11, 2025 11:05
@changeset-bot
Copy link

changeset-bot bot commented Feb 11, 2025

⚠️ No Changeset found

Latest commit: 9712be1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Feb 11, 2025

Branch preview

Review the following VRT differences

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

@github-actions
Copy link
Contributor

Tachometer results

Currently, no packages are changed by this PR...

@rubencarvalho rubencarvalho changed the title chore: update fields css dependencies chore: update field components css dependencies Feb 11, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 11, 2025

Lighthouse scores

Category Latest (report) Main (report) Branch (report)
Performance 0.99 0.97 0.98
Accessibility 1 1 1
Best Practices 1 1 1
SEO 1 0.92 0.92
PWA 1 1 1
What is this?

Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but note that the SEO scores on Netlify URLs are artifically constrained to 0.92.

Transfer Size

Category Latest Main Branch
Total 244.579 kB 230.643 kB 229.251 kB 🏆
Scripts 61.394 kB 54.21 kB 53.995 kB 🏆
Stylesheet 47.182 kB 42.004 kB 40.794 kB 🏆
Document 6.25 kB 5.484 kB 🏆 5.485 kB
Font 126.894 kB 126.596 kB 126.596 kB

Request Count

Category Latest Main Branch
Total 52 52 52
Scripts 41 41 41
Stylesheet 5 5 5
Document 1 1 1
Font 2 2 2

@rubencarvalho rubencarvalho force-pushed the ruben/bump-field-components-css branch from b610eb1 to 6e5b75c Compare February 12, 2025 11:29
@Rajdeepc Rajdeepc force-pushed the ruben/bump-field-components-css branch from b610eb1 to 6e5b75c Compare February 12, 2025 11:50
@coveralls
Copy link
Collaborator

coveralls commented Feb 13, 2025

Pull Request Test Coverage Report for Build 13658295216

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 97.963%

Totals Coverage Status
Change from base Build 13656433941: -0.003%
Covered Lines: 33662
Relevant Lines: 34164

💛 - Coveralls

@rubencarvalho rubencarvalho force-pushed the ruben/bump-field-components-css branch from 4baaf8b to a9a30ea Compare March 4, 2025 08:23
@rubencarvalho rubencarvalho merged commit b5ee3c2 into main Mar 4, 2025
27 checks passed
@rubencarvalho rubencarvalho deleted the ruben/bump-field-components-css branch March 4, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants